fix: Improve extraction of inline XML #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
previously approved these changes
Feb 19, 2025
The previous implementation extracted XML content from every options property, not just the actual XML definition/content. This lead to unnecessary empty inline JS files. Follow-up of #519
matz3
force-pushed
the
improve-inline-xml-detection
branch
from
43d2ff6 to
6e42901
Compare
d3xter666
reviewed
Feb 19, 2025
| { | ||
| column: 17, | ||
| line: 33, | ||
| message: 'Call to deprecated function \'sapUiXmlView\'', |
There was a problem hiding this comment.
The deprecation is correct, but to me this seems a bit missleading. There's no such thing as sapUiXmlView, but its assignment. While in the example, the solution is obvious, in real code this might not be the case and might lead to ambiguous situations
There was a problem hiding this comment.
We might try to enhance this in general by adding the original API name to the message. This is sometimes working, but I think in this case it does not, as the additionalMessage is empty.
codeworrior
reviewed
Feb 19, 2025
matz3
force-pushed
the
improve-inline-xml-detection
branch
from
88a7fb3 to
df6c3ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation extracted XML content from every options
property, not just the actual XML definition/content.
This lead to unnecessary empty inline JS files.
Follow-up of #519