Open
Conversation
Member
|
Hi Shahzeb, Thank you for this suggestion. However, I guess there are some other things we need to put in place for it to work in your scenario. The MiddlewareManager needs to expose the configuration option of the CSP middleware so that karma-ui5 (and UI5 CLI) can expose it as well. On that note, we'd probably opt for an option that also allows to define the file path. Since you are only interested in the final report, we should also add a debouncing. Limiting file updates to only take place if no new data has arrived for ~one second. And of course we also need to add unit tests for this feature. We'll track this internally as CPOUI5FOUNDATION-436. Please reach out to Andreas in case this is of high priority for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@matz3 as discussed before in a meeting, i would like to propose a change directly to middleware than writing my own middleware or changing karma settings. It will generate a json file in current folder which can be later consumed as needed.