Skip to content

[FIX] Explicitly bind to IPv4 loopback #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RandomByte wants to merge 1 commit into
base: v4
Choose a base branch
from
Open

[FIX] Explicitly bind to IPv4 loopback #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,19 @@ function _listen(app, port, changePortIfInUse, acceptRemoteConnections) {
const options = {};

if (!acceptRemoteConnections) {
options.host = "localhost";
}
// Unless remote connections are allowed, bind to the IPv4 loopback address
options.host = "127.0.0.1";
} // If remote connections are allowed, do not set host so the server listens on all supported interfaces

const host = options.host || "127.0.0.1";
const portScanHost = options.host || "127.0.0.1";
let portMax;
if (changePortIfInUse) {
portMax = port + 30;
} else {
portMax = port;
}

portscanner.findAPortNotInUse(port, portMax, host, function(error, foundPort) {
portscanner.findAPortNotInUse(port, portMax, portScanHost, function(error, foundPort) {
if (error) {
reject(error);
return;
Expand All @@ -49,15 +50,15 @@ function _listen(app, port, changePortIfInUse, acceptRemoteConnections) {
`EADDRINUSE: Could not find available ports between ${port} and ${portMax}.`);
error.code = "EADDRINUSE";
error.errno = "EADDRINUSE";
error.address = host;
error.address = portScanHost;
error.port = portMax;
reject(error);
return;
} else {
const error = new Error(`EADDRINUSE: Port ${port} is already in use.`);
error.code = "EADDRINUSE";
error.errno = "EADDRINUSE";
error.address = host;
error.address = portScanHost;
error.port = portMax;
reject(error);
return;
Expand Down
8 changes: 4 additions & 4 deletions test/lib/server/ports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test.serial("Start server - Port is already taken and an error occurs", async (t
);
t.is(
error.address,
"localhost",
"127.0.0.1",
"Correct error address"
);
t.is(
Expand Down Expand Up @@ -89,7 +89,7 @@ test.serial("Start server together with node server - Port is already taken and
});

t.deepEqual(server.port, nextFoundPort, "Resolves with correct port");
const request = supertest(`http://localhost:${nextFoundPort}`);
const request = supertest(`http://127.0.0.1:${nextFoundPort}`);
const result = await request.get("/index.html");
if (result.error) {
t.fail(result.error.text);
Expand Down Expand Up @@ -181,7 +181,7 @@ test.serial(
);
t.is(
error.address,
"localhost",
"127.0.0.1",
"Correct error address"
);
t.is(
Expand Down Expand Up @@ -213,7 +213,7 @@ test.serial("Start server twice - Port is already taken and the next one is used
});
t.deepEqual(serveResult2.port, nextFoundPort, "Resolves with correct port");

const request = supertest(`http://localhost:${nextFoundPort}`);
const request = supertest(`http://127.0.0.1:${nextFoundPort}`);
const result = await request.get("/index.html");
if (result.error) {
t.fail(result.error.text);
Expand Down