-
Notifications
You must be signed in to change notification settings - Fork 273
feat(ui5-li): add text wrapping support #11108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kgogov
wants to merge
17
commits into
main
Choose a base branch
from
feat-list-wrapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf65704
to
10f7b58
Compare
7060ff3
to
166940b
Compare
07401f2
to
9a78e32
Compare
dobrinyonkov
requested changes
Mar 26, 2025
6ab4f6b
to
744e6f1
Compare
57a1c86
to
2d144d4
Compare
dobrinyonkov
reviewed
Apr 1, 2025
af1dd1c
to
2a8cc13
Compare
dobrinyonkov
reviewed
Apr 2, 2025
packages/main/src/features/ListItemStandardExpandableTextTemplate.tsx
Outdated
Show resolved
Hide resolved
The standard list item ui5-li now supports content wrapping through a publicly available wrappingType property. When set to "Normal", long text content (title and description) will wrap to multiple lines instead of truncating with an ellipsis.
- Updated the ListItemStandard class and ListItemStandardTemplate - Updated CSS selectors to work with wrapping-type="Normal" attribute - Updated the available test cases - Updated the documentation - Updated the samples
- Add ExpandableTextTemplateParams type to handle text template parameters - Create ListItemStandardExpandableTextTemplate component for expandable text - Update ListItemStandard and ListItemStandardTemplate to support text wrapping - Extract shared interface to types folder to avoid duplication
Implement preloadable expandable text template for ListItemStandard when using wrappingType="Normal". Create ListItemStandardExpandableText.ts to allow users to preload the feature instead of using dynamic imports. Update documentation and component test imports accordingly.
2a8cc13
to
82d5701
Compare
38784d9
to
5ec8119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The standard list item
ui5-li
now supports content wrapping through a publicly availablewrappingType
property. When set to "Normal", long text content (title and description) will wrap to multiple lines instead of truncating with an ellipsis.Key features:
ui5-expandable-text
Implementation details:
wrappingType
property public available with options "None" (default) and "Normal"ui5-expandable-text
component whenwrappingType
is "Normal"_maxCharacters
getter to determine truncation point based on media rangewrapping-type
attributeListItemStandardExpandableText.ts
to support preloading the expandable text featureDocumentation:
default
slot in favor oftext
propertyTests:
wrappingType
propertyNOTE: This change also promotes the use of the
text
property (added inv2.10.0
) instead of thedefault
slot content for setting list item text. Thedefault
slot usage is now deprecated and will be removed in a future version.Implements: #9745