Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-select): add listbox role to meet ARIA parent-child requirements #11156

Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix(ui5-select): add listbox role to meet ARIA parent-child requirements #11156

merged 1 commit into from
Mar 28, 2025
+1 −0

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Mar 21, 2025 •
edited
Loading

Problem:

  • List items with role="option" lack required parent with role="listbox".

Solution:

  • Set accessibleRole="ListBox" on List component to establish proper ARIA hierarchy.

Fixes: #11151
Fixes: #11152

@NakataCode NakataCode mentioned this pull request Mar 21, 2025
Closed
1 task
@NakataCode NakataCode marked this pull request as ready for review March 21, 2025 13:15
@NakataCode NakataCode merged commit dcb4edc into main Mar 28, 2025
12 checks passed
@NakataCode NakataCode deleted the select-listbox-role branch March 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamenivanov91 plamenivanov91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NakataCode @plamenivanov91