-
Notifications
You must be signed in to change notification settings - Fork 276
refactor(ui5-menu): remove references to parent #11217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
reviewed
Mar 31, 2025
nnaydenow
reviewed
Mar 31, 2025
hinzzx
requested changes
Apr 3, 2025
hinzzx
reviewed
Apr 9, 2025
hinzzx
reviewed
Apr 9, 2025
hinzzx
reviewed
Apr 15, 2025
hinzzx
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please re-base to main
branch since few WDIO tests are failing, I believe due to old ChromeDriver version.
hinzzx
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good from my side
nnaydenow
reviewed
Apr 22, 2025
nnaydenow
reviewed
May 9, 2025
nnaydenow
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
ui5-menu
closing and navigation handling, removing references to the parent element:MenuItems
now close their own submenus when necessary.Menu
orMenuItem
.MenuItem
with a submenu.