-
Notifications
You must be signed in to change notification settings - Fork 274
docs(UXC Pattern): extend with shellbar search and user menu #11443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request extends the UXC Pattern sample documentation by integrating a shellbar search with multiple search scopes and replacing the profile popover with a user menu component. Key changes include:
- Replacing the ui5-input with a ui5-shellbar-search element that supports multiple search scopes.
- Replacing the ui5-popover with a ui5-user-menu component to provide enhanced user account actions.
- Updating the main.js file to import the necessary modules and add event handlers for the new search and user menu components.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/website/docs/_samples/patterns/UXCIntegration/Basic/sample.html | Updated markup for shellbar search and introduced a new user menu component with account details. |
packages/website/docs/_samples/patterns/UXCIntegration/Basic/main.js | Removed ui5-input dependencies, added imports for new components, and implemented event handling for user menu and search functionality. |
Comments suppressed due to low confidence (1)
packages/website/docs/_samples/patterns/UXCIntegration/Basic/sample.html:58
- [nitpick] The label 'Setting' might be ambiguous. Consider renaming it to 'Settings' to follow common UI text conventions.
<ui5-user-menu-item icon="action-settings" text="Setting" data-id="setting"></ui5-user-menu-item>
<ui5-user-menu-account slot="accounts" | ||
avatar-initials="DS" | ||
title-text="David Wilson" | ||
subtitle-text="davud,[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typographical error in the email address ('davud,[email protected]'). Consider correcting it to a standard format (e.g., '[email protected]').
subtitle-text="davud,[email protected]" | |
subtitle-text="david.[email protected]" |
Copilot uses AI. Check for mistakes.
console.log("Product-specific account action 1"); | ||
break; | ||
case "account-action2": | ||
console.log("Product-specific account action 2"); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The switch statement in the user menu event handler includes cases for 'account-action1' and 'account-action2', yet these actions are not present in the sample HTML. Consider removing or updating these cases to match the available menu items.
case "account-action1": | |
console.log("Product-specific account action 1"); | |
break; | |
case "account-action2": | |
console.log("Product-specific account action 2"); | |
break; | |
// Removed unused cases for "account-action1" and "account-action2". |
Copilot uses AI. Check for mistakes.
Internal Reference: BGSOFUIPIRIN-6810