Skip to content

fix(ui5-input): emit change when suggestion is clicked #12206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

fix(ui5-input): emit change when suggestion is clicked #12206

merged 1 commit into from
Sep 1, 2025

Conversation

aleksandar-terziev
Copy link
Contributor

Fixes - #12179

  • Previously, clicking a suggestion after fully typing the same text did not fire change; now both mouse and keyboard selection paths are consistent
  • clicking a suggestion now emits a change event in addition to the existing selection-change

Vonahz
Vonahz reviewed Sep 1, 2025
View reviewed changes
@aleksandar-terziev aleksandar-terziev merged commit 50bb5e6 into main Sep 1, 2025
19 of 20 checks passed
@aleksandar-terziev aleksandar-terziev deleted the input-change-on-click branch September 1, 2025 11:19
@aleksandar-terziev aleksandar-terziev mentioned this pull request Sep 1, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vonahz Vonahz Vonahz approved these changes

@ndeshev ndeshev Awaiting requested review from ndeshev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandar-terziev @Vonahz