Sb/funwave fix wl #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabySalgado
reviewed
Jul 22, 2021
Collaborator
GabySalgado
left a comment
GabySalgado
left a comment
There was a problem hiding this comment.
Just to be sure: you are adding the WL only to r2 and setup, not to the eta time series?
Collaborator
|
@SBFRF, why does this say funwave fix wl but it has a bunch of changes to the stwave setup? |
Owner
Author
|
Shoot, trousers should be separate pr’s
…------
Spicer Bak
Research Coastal Engineer
Field Research Facility, Duck NC
Sent from my personal phone
On Jul 23, 2021, at 11:17 AM, Ty Hesser ***@***.***> wrote:
@SBFRF, why does this say funwave fix wl but it has a bunch of changes to the stwave setup?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Collaborator
|
@SBFRF I don't mind approving it. Doesn't seem to affect anything that I am worried about. I will leave it in your court. |
Owner
Author
|
Yes it’s totally independent development, but bad practice certainly
…------
Spicer Bak
Research Coastal Engineer
Field Research Facility, Duck NC
Sent from my personal phone
On Jul 23, 2021, at 2:20 PM, Ty Hesser ***@***.***> wrote:
@SBFRF I don't mind approving it. Doesn't seem to affect anything that I am worried about. I will leave it in your court.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Owner
Author
|
Gaby you’re right. I have to look at this/update before approving. … this is why we do this!
…------
Spicer Bak
Research Coastal Engineer
Field Research Facility, Duck NC
Sent from my personal phone
On Jul 22, 2021, at 1:26 PM, GabySalgado ***@***.***> wrote:
@GabySalgado commented on this pull request.
Just to be sure: you are adding the WL only to r2 and setup, not to the eta time series?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing water level, confirmed that WL is not adjusted in prepdata, and is adjusted in front back