Define 2d model class and Simmetrix GeomSim model loader#96
Open
Define 2d model class and Simmetrix GeomSim model loader#96
Conversation
cwsmith
changed the title
simmetrix does not store loops, only loop uses, remove them for now
compiles and executes
no leaks or errors under valgrind
jacobmerson
reviewed
Apr 7, 2024
Collaborator
jacobmerson
left a comment
jacobmerson
left a comment
There was a problem hiding this comment.
I mostly commented on high level design choices so far.
joshia5
reviewed
Apr 18, 2024
joshia5
reviewed
Apr 18, 2024
joshia5
reviewed
May 1, 2024
Collaborator
|
looks good to me overall, some comments attached |
Author
|
notes from discussion with @jacobmerson
|
Stores topological data in private fields and provides a "getter" api to access topological data. Also adds in code doxygen documentation.
Adds topological queries to the Model2D Class by: - Making the Model2D Fields private, and providing inline "getter" functions - Reworking the Model2D loading routine. It now utilizes private helper functions to populate the Model2D Fields - Adding documentation with doxygen This PR also bumps the maximum version of Simmetrix to 2025.1.250507.
Author
|
/runtests |
|
Test Result: success (details) |
Author
|
/runtests |
|
Test Result: success (details) |
jacobmerson
reviewed
Sep 14, 2025
| } | ||
|
|
||
| std::optional<Model2D> Mesh2D::getModel() const { | ||
| std::optional<const Model2D> Mesh2D::getModel() const { |
Collaborator
There was a problem hiding this comment.
This may not be what you want. I'm pretty sure this will make a copy of the model to return since std::optional owns the data. If you don’t want a copy a pointer is probably the way to go here, but with an added note in the docs that it may be null since our users may not be as careful with checking for nullptr as they should be.
If you return a pointer, you can also mark this function noexcept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Model2D class and support for filling the Model2D data structures from a Simmetrix GeomSim model (.smd).
will_fail_test_func(...)CMake macro)