Minor change to search_mesh_3d function definition

[zhangchonglin]

Minor change to search_mesh_3d function definition to be consistent with search_mesh_2d function.
search_mesh_2d function is defined as:

pumi-pic/src/pumipic_adjacency.hpp

Lines 1010 to 1020 in a9f7f8e

	template < class ParticleStruct, typename CurrentCoordView,
	typename TargetCoordView, typename SegmentInt>
	bool search_mesh_2d(o::Mesh& mesh, // (in) mesh
	ParticleStruct* ptcls, // (in) particle structure
	CurrentCoordView x_ps_d, // (in) starting particle positions
	TargetCoordView xtgt_ps_d, // (in) target particle positions
	SegmentInt pid_d, // (in) particle ids
	o::Write<o::LO> elem_ids, // (out) parent element ids for the target positions
	int looplimit=0, // (in) [optional] number of loops before giving up
	bool debug = false) {

[cwsmith]

Thank you @zhangchonglin.

Our automated testing is having issues at the moment. Are all tests passing (that you ran with your specific config) with this change?

[zhangchonglin]

@cwsmith: all tests are passing except 31, which I think was not passing previously.

The following tests FAILED:
	 31 - moller_trumbore_test (Failed)

[jacobmerson]

@Fuad-HH I believe you were doing some work with that particular test. Can you comment on its current status?

[Fuad-HH]

@Fuad-HH I believe you were doing some work with that particular test. Can you comment on its current status?

It passed with my configuration (with both Kokkos CUDA and OpenMP) and, if I remember correctly, it passed the automated testing too. If I could get the terminal output for the test, I would be able to guess what's going wrong there. My first guess will be the pumipic-data repository doesn't have the necessary meshes. Please try checking if the directory contains the latest commits from this repository: https://github.com/SCOREC/pumipic-data

[zhangchonglin]

Updating the https://github.com/SCOREC/pumipic-data, all tests are passing.

[dhyan1272]

I have built GITRm with the latest software stack, Once I am able to run, I will do the check

[cwsmith]

@zhangchonglin Would you mind merging master into this branch or rebasing on master?