Deprecate MyPair

[Sichao25]

Deprecated the MyPair struct, which is not used in any current functionality. Kokkos::pair is preferred for any scenarios requiring similar data structures.

[cwsmith]

Thank you @Sichao25. Before this can be merged we need to check that GITRm, XGCm, COMET, and PUMI-Tally aren't using this interface. You should have access to the GITRm and XGCm repos. I'm not sure about PUMI-Tally.

@zhangchonglin Would you please grep for PairView in COMET?

[zhangchonglin]

Thank you @cwsmith, @Sichao25. Comet is not using PairView. Actually, I also have to delete part of that function (the use of that) to compile on Aurora:

#ifdef PP_USE_GPU
namespace Kokkos {
  using pumipic::MyPair;
  PP_DEVICE_VAR MyPair ma = MyPair(10000000);
  PP_DEVICE_VAR MyPair mi = MyPair(0);
  template <>
  struct reduction_identity<MyPair> {
    KOKKOS_FORCEINLINE_FUNCTION constexpr static const MyPair& max() {return ma;}
    KOKKOS_FORCEINLINE_FUNCTION constexpr static const  MyPair& min() {return mi;}
  };
}
#endif

[jacobmerson]

I was thinking we could start with the ``[[deprecated]]` attribute, but if we can confirm that none of the downstream applications make use of this I'm fine with completely removing it.

[jacobmerson]

PumiTally does not use this.
@dhyan1272 do you use any MyPair in GITRM?

[dhyan1272]

No I do not use it in GITRm

[cwsmith]

Given that we are changing the API (albeit an apparently unused portion), I think we should increase the major version number in CMakeLists.txt. Thoughts?

[jacobmerson]

Given that we are changing the API (albeit an apparently unused portion), I think we should increase the major version number in CMakeLists.txt. Thoughts?

I agree.

[jacobmerson]

@Sichao25 I think as soon as you bump the version number in the CMakeLists.txt we can merge this.