fix function call typo causing no retry mechanism in ninja daemon startup #4147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a silly typo which I am pretty sure is responsible for intermittent issues seen in the CI.
The ninja scons daemon server startup script will launch the daemon process, then attempt to connect to the server to make sure the server is running before exiting 0 (letting ninja know the server has started successfully). On slower systems the server may not respond fast enough and a connection refused will be issued. The client attempting to connect should retry in this situation in hopes the server is ready to respond in subsequent attempts to connect.
The startup script has this logic, and it will also not retry if the server process has been confirmed killed via subprocess.poll() = not None. The issue is that the code omitted the parenthesis's and anytime a retry was needed, it would immediately end prematurely in failure.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)