Updated SHELL_ENV_GENERATOR to be list of functions now called SHELL_ENV_GENERATORS #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbaddog
reviewed
May 26, 2022
CHANGES.txt
Outdated
| Now setting NINJA_DEPFILE_PARSE_FORMAT to [msvc,gcc,clang] can force the ninja expected | ||
| format. Compiler tools will also configure the variable automatically. | ||
| - Added SHELL_ENV_GENERATOR construction variables. This variable allows the user to Define | ||
| - Added SHELL_ENV_GENERATOR construction variable. This variable allows the user to Define |
Contributor
There was a problem hiding this comment.
Can collapse these two entries.
bdbaddog
reviewed
May 26, 2022
RELEASE.txt
Outdated
| - Added SHELL_ENV_GENERATOR construction variables. This variable allows the user to Define | ||
| a function which will be called to generate or alter the execution environment which will | ||
| be used in the shell command of some Action. | ||
| - Updated SHELL_ENV_GENERATOR construction variable to SHELL_ENV_GENERATORS. This variable |
Contributor
There was a problem hiding this comment.
can collapse these two entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream mongodb implemented the original SHELL_ENV_GENERATOR and found that it was limiting having a single slot to store such functions and required cumbersome chaining techniques.
This PR updates the variable to be a list of functions that will be called to modify the execution environment for a given action.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)