Normalize use of test.sleep() #4164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests used time.sleep while others used the harness's test.sleep, the ones that are done for file timestamp delay management now all use test.sleep - with a consistent comment, so it's easier to spot. There are still tests that use time.sleep with smaller intervals that were left alone. Affected tests were reformatted, in the spirit of gradually improving tests that you otherwise touch... Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
added
the
testsuite
Signed-off-by: Mats Wichmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier change relating to testing delays for timestamp consistency exposed that some tests used
time.sleepwhile others used the harness'stest.sleep. This change adjusts the ones that are done for file timestamp delay management to consistently all usetest.sleep- with an annotation, so it's easier to spot. There are still tests that usetime.sleepwith other intervals that were left alone.Affected tests were reformatted, in the spirit of gradually improving tests that you otherwise touch...
This is a test-only change.
Signed-off-by: Mats Wichmann [email protected]
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)