[NINJA] Added new alias 'shutdown-ninja-scons-daemon' to allow ninja to shutdown the daemon #4170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoody256
changed the title
…test. Added note to CHANGES.txt/RELEASE.txt that psutil is required for the new test for this function
Contributor
|
Many of the windows ninja experimental tests are failing. |
Contributor
Author
@bdbaddog fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new alias for users to be able to shutdown the daemon gracefully on command. Also added clean up abilities to test framework to shutdown all daemons and remove scons daemon log directories if preserve is not set.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)