find_program_path() can now add discovered path #4175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tools contain a stanza like this, usually for the Windows case,
where installed programs are rarely added to the "standard" path
in SCons' execution environment (i.e. env['ENV']["PATH']):
javac = SCons.Tool.find_program_path(env, 'javac', default_paths=paths)
if javac:
javac_bin_dir = os.path.dirname(javac)
env.AppendENVPath('PATH', javac_bin_dir)
This change adds a keyword argument add_path to find_program_path() to
instruct it to add the path a program was discovered in, if it was in the
extra paths passed in. The default is False, retaining the existing behavior.
Signed-off-by: Mats Wichmann <[email protected]>
bdbaddog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tools contain a stanza like this, usually for the Windows case, where installed programs are rarely added to the "standard" path in SCons' execution environment (i.e.
env['ENV']["PATH']):This change adds a keyword argument
add_pathtofind_program_path()to instruct it to add the path a program was discovered in, if it was in the extra paths passed in. The default is False, retaining the existing behavior.Signed-off-by: Mats Wichmann [email protected]
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)