Skip to content

Conversation

@mwichmann
Copy link
Collaborator

Where string pasting is done using test or interpreter paths, make sure they're pasted as raw strings to avoid problems on the Windows platform, where the likely presence of '\Users' is likely to cause a unicode error.

Note the framework tests aren't normally run by the CI.

Signed-off-by: Mats Wichmann [email protected]

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

Where string pasting is done using test or interpreter paths, make sure
they're pasted as raw strings to avoid problems on the Windows platform,
where the likely presence of '\Users` is likely to cause a unicode error.

Signed-off-by: Mats Wichmann <[email protected]>
@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Jun 14, 2022
@bdbaddog bdbaddog merged commit fb6c94a into SCons:master Jun 14, 2022
@mwichmann mwichmann added this to the 4.4 milestone Jun 15, 2022
@mwichmann mwichmann deleted the testfw/windowscompat branch June 15, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants