Fortran variants now include FORTRANCOMMONFLAGS #4180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation suggested $FORTRANFLAGS was included in the build lines for all variants, but it was not. Turns out the test suite quite explicitly checks that FORTRANFLAGS doesn't leak through to other variants, so instead define a new FORTRANCOMMONFLAGS to serve the purpose of a flag that applies to all variants. Assorted cleanup. And f-strings. Fixes SCons#2257 Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
added
Tools
mwichmann
changed the title
bdbaddog
reviewed
Jun 16, 2022
bdbaddog
reviewed
Jun 16, 2022
Remove leftover debugging debris. Fix sider complaint Signed-off-by: Mats Wichmann <[email protected]>
Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
feature/fortrancommonflags
branch
from
abf6c87 to
847ea0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation hinted that
$FORTRANFLAGSwas included in the build lines for all dialects, but it was not. Turns out, the test suite quite explicitly checks thatFORTRANFLAGSdoesn't leak through to other variants, so instead define a newFORTRANCOMMONFLAGSto serve the purpose of a flag that applies to all variants.Assorted cleanup. And f-strings.
Fixes #2257
Signed-off-by: Mats Wichmann [email protected]
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)