Improvements to lex and yacc tools #4183
Conversation
The mocked tools mylex.py and myyacc.py now understand the file-generation options, and generate a dummy file with predictable contents, for checking. This allows more testing of the path through the SCons support for these two without needing live commands. New tests added which invoke the file-generation options, and make sure the extra files are created, and that SCons detects and tracks the added targets. Work is done in a subdirectory, which exposes some existing known inconsistent behavior (the regular generated file goes in the subdir per the LEXCOM and YACCOM generated line, while the ones generated from commandline options go in the topdir) - but we're going to allow that behavior to continue for backwards compat. Same fix applied to yacc tool that PR SCons#4168 did for lex - do subst_list() instead of subst() to preserve spaces in paths. That fix left the lex tool unable to pass the new test, as it could not see the individual arguments in the FLAGS variable, which was solved by indexing into the subst'd list so we can iterate over the args again. Test and tool cleanup; add DefaultEnvironment calls, etc. Note this mentions, but does not address the problem described in issue 4154. Signed-off-by: Mats Wichmann <[email protected]>
Signed-off-by: Mats Wichmann <[email protected]>
|
Question: issue #4154 is mentioned in code comments, but not in the updated manpage sections. This is because there's no replacement yet - didn't feel like saying "this won't be completely correct if you are in a subdirectory (including variant directory), be we can't tell you what to use instead". Should it be mentioned in some way? |
| but was not applied to other dialects, and e2e tests explicitly checked | ||
| that FORTRANFLAGS did not propagate outside the FORTRAN dialect, | ||
| so the conclusion is that behavior is intentional (issue #2257) | ||
| - Improvements to lex and yacc tools: better documentation of |
There was a problem hiding this comment.
add which flags are interpretted correctly now? also add blurb to RELEASE.txt?
There was a problem hiding this comment.
The only behavioral change is in Tool/lex.py: the previous lex PR left us with a list-of-lists after the change from subst to subst_list on LEXFLAGS, which meant we couldn't iterate over the results. That's not material for RELEASE - the briefly broken bit was never visible in an SCons release. I don't know if you want that mentioned in CHANGES: fix interpretation of LEXFLAGS in one very specific circumstance (previously untested) which was broken for a few days. Let me know...
2 participants
The mocked tools
mylex.pyandmyyacc.pynow understand the file-generation options, and generate a dummy file with predictable contents, for checking. This allows more testing of the path through the SCons support for these two without needing live commands.New tests added which invoke the file-generation options, and make sure the extra files are created, and that SCons detects and tracks the added targets. Work is done in a subdirectory, which exposes some existing known inconsistent behavior (the regular generated file goes in the subdir per the
LEXCOMandYACCOMgenerated line, while the ones generated from command line options go in the topdir) - but we're going to allow that behavior to continue for backwards compat.Same fix applied to yacc tool that PR #4168 did for lex -
do subst_list()instead ofsubst()to preserve spaces in paths. That fix left the lex tool unable to pass the new test, as it could not see the individual arguments in theFLAGSvariable, which was solved by indexing into the subst'd list so we can iterate over the args again.Test and tool cleanup; add
DefaultEnvironmentcalls, etc.Note this mentions, but does not address the problem described in issue 4154.
Signed-off-by: Mats Wichmann [email protected]
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)