Open
Conversation
gyeongbibin
reviewed
May 11, 2026
| import reactHooks from "eslint-plugin-react-hooks"; | ||
| import reactRefresh from "eslint-plugin-react-refresh"; | ||
| import tseslint from "typescript-eslint"; | ||
| import prettierConfig from "eslin-config-prettier"; |
Collaborator
There was a problem hiding this comment.
eslin -> eslint 오타 났어요 !
| import reactRefresh from "eslint-plugin-react-refresh"; | ||
| import tseslint from "typescript-eslint"; | ||
| import prettierConfig from "eslin-config-prettier"; | ||
| import prettierPlugin, { rules } from "eslint-plugin-prettier"; |
Collaborator
There was a problem hiding this comment.
rules import는 eslint-plugin-prettier 내부 규칙 객체를 가져오는 건데, rules는 사용하지 않아서
import prettierPlugin from "eslint-plugin-prettier"; 이렇게만 둬도 될거같네용
| "simple-import-sort": simpleImportSort, | ||
| }, | ||
| rules: { | ||
| "prettier/prettier": error, |
Collaborator
There was a problem hiding this comment.
"prettier/prettier": "error" 처럼 error를 문자열로 !
|
|
||
| export default defineConfig([ | ||
| globalIgnores(['dist']), | ||
| globalIgnores(["dist", "node-modules"]), |
Collaborator
There was a problem hiding this comment.
node-modules → node_modules 오타 수정 부탁드립니다!
Collaborator
Author
There was a problem hiding this comment.
오타가 많았네요ㅜㅜ 다음부턴 더 꼼꼼하게 확인하겠습니다...!! 감사합니다🙇♀️
Member
|
충돌 해결이랑 추가로 셋팅할 게 좀 있어서 서진이 양해구하고 제가 수정 좀 했습니다!! 수정사항
변경된 환경에서 Ctrl+s로 테스트도 해봤습니다!!! |
chungyo
reviewed
May 11, 2026
Collaborator
chungyo
left a comment
chungyo
left a comment
There was a problem hiding this comment.
고생하셨어용~ 처음 하시는건데 열심히 하신게 보이네요..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
📚 Tasks
🔍 Describe
👀 To Reviewer