Skip to content

change allowedToScaleDown logic #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andriyvasylyna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change allowedToScaleDown logic #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,11 @@ func allowedToScaleDown(ctx hpaScopedContext) (bool, error) {
// in here we are relying no HPAs condition for defining if scaling down is allowed
if condition.Type == "AbleToScale" && condition.Status == v1.ConditionTrue && condition.Reason == "ReadyForNewScale" {
return true, nil
// if behaviour does not allow scaling now AbleToScale condition will have ScaleDownStabilized reason
} else if (condition.Type == "AbleToScale" && condition.Status == v1.ConditionFalse) ||
(condition.Type == "AbleToScale" && condition.Reason == "ScaleDownStabilized" && condition.Status == v1.ConditionTrue) ||
(condition.Type == "ScalingLimited" && condition.Reason == "ScaleDownLimit") {
} else if condition.Type == "AbleToScale" && (condition.Reason != "ReadyForNewScale" || condition.Status == v1.ConditionFalse) {
ctx.logger.Info(fmt.Sprintf("HPA's not able to scale with reason: %s", condition.Reason))
return false, nil
} else if condition.Type == "AbleToScale" && condition.Reason == "ScaleDownStabilized" && condition.Status == v1.ConditionTrue {
ctx.logger.Info("HPA scaling down is stabilized. Scaling down to fast")
return false, nil
}
}
Expand Down
Loading