Skip to content

chore: fix .nvmrc documentation link and add explicit permissions to workflows#21

Merged
jboix merged 2 commits into
mainfrom
docs/fix-nvmrc-link
Mar 10, 2026
Merged

chore: fix .nvmrc documentation link and add explicit permissions to workflows#21
jboix merged 2 commits into
mainfrom
docs/fix-nvmrc-link

Conversation

@jboix
Copy link
Copy Markdown
Member

@jboix jboix commented Feb 26, 2026

Changes Made

  • Added missing .nvmrc documentation link.
  • Secure all workflows by adding explicit permissions.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

The link to the .nvmrc documentation was missing.
Secure all workflows by adding explicit permissions.
@jboix jboix requested a review from amtins February 26, 2026 09:50
@jboix jboix self-assigned this Feb 26, 2026
@jboix jboix added this to Pillarbox Feb 26, 2026
@github-project-automation github-project-automation Bot moved this to 📋 Backlog in Pillarbox Feb 26, 2026
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 92.02% 150 / 163
🔵 Statements 91.17% 155 / 170
🔵 Functions 93.93% 62 / 66
🔵 Branches 71.42% 40 / 56
File CoverageNo changed files found.
Generated in workflow #53 for commit 12c9396 by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-10 09:37 UTC

@jboix jboix moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Mar 10, 2026
Copy link
Copy Markdown
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit 8ddb7d1 Mar 10, 2026
5 checks passed
@jboix jboix deleted the docs/fix-nvmrc-link branch March 10, 2026 09:36
@github-project-automation github-project-automation Bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants