-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diego thermodynamic fix #189
Diego thermodynamic fix #189
Conversation
Failed the aiida test with "ValueError: required pseudo family |
Hi, this is strange, |
Yep, it also failed in the old code. Something changed in the AiiDa. |
True, let me try to fix it on the master workflow, so you can pull that into this branch and then merge. Pull request #190 |
Taken out the AiiDa second test it compiles OK. |
Ok, I would avoid removing the test, @bastonero is looking into it right now ;) |
Last commit undone. |
Just opened the PR! (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes have been discussed throught the issues and the pull request comments.
This pull request fix the dependency issue of spglib and the module Thermodynamics compilation issue with numpy distutils.
The fix for the Thermodynamic error inside "Ensemble.py".