Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diego thermodynamic fix #189

Merged

Conversation

diegomartinez2
Copy link
Collaborator

The fix for the Thermodynamic error inside "Ensemble.py".

diegomartinez2 and others added 30 commits June 10, 2022 12:38
@diegomartinez2
Copy link
Collaborator Author

Failed the aiida test with "ValueError: required pseudo family SSSP/1.3/PBEsol/efficiency is not installed. Please use aiida-pseudo install toinstall it."

@mesonepigreco
Copy link
Collaborator

Hi, this is strange,
I am rerunning an old job to see if it was working the AiiDA part, or if it is another error introduced by an updated from the AiiDA people.

@diegomartinez2
Copy link
Collaborator Author

Yep, it also failed in the old code. Something changed in the AiiDa.

@mesonepigreco
Copy link
Collaborator

mesonepigreco commented Feb 7, 2024

True, let me try to fix it on the master workflow, so you can pull that into this branch and then merge. Pull request #190

@diegomartinez2
Copy link
Collaborator Author

Taken out the AiiDa second test it compiles OK.

@mesonepigreco
Copy link
Collaborator

Ok, I would avoid removing the test, @bastonero is looking into it right now ;)
If you undo the last commit I merge even if it does not pass, otherwise, when @bastonero fixes the test we will have a merge conflict.

@diegomartinez2
Copy link
Collaborator Author

Last commit undone.

@mesonepigreco mesonepigreco self-assigned this Feb 7, 2024
@bastonero
Copy link
Contributor

Just opened the PR! (:

@mesonepigreco mesonepigreco added this to the 1.4.1 milestone Feb 7, 2024
@mesonepigreco mesonepigreco self-requested a review February 7, 2024 11:25
Copy link
Collaborator

@mesonepigreco mesonepigreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes have been discussed throught the issues and the pull request comments.
This pull request fix the dependency issue of spglib and the module Thermodynamics compilation issue with numpy distutils.

@mesonepigreco mesonepigreco merged commit a048fa8 into SSCHAcode:master Feb 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants