Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SSSP version to 1.3 in tests #191

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

bastonero
Copy link
Contributor

Aiida-quantumespresso protocols now use SSSP v1.3 by default. The older 1.2 would make the tests to fail. A simple update of the version now fixes the aiida tests.

bastonero and others added 2 commits February 7, 2024 11:22
Aiida-quantumespresso protocols now use SSSP v1.3 by default.
The older 1.2 would make the tests to fail. A simple update of the
version now fixes the aiida tests.
@mesonepigreco mesonepigreco self-assigned this Feb 7, 2024
@mesonepigreco mesonepigreco added this to the 1.4.1 milestone Feb 7, 2024
@mesonepigreco mesonepigreco added the cleaning cleaning of the code label Feb 7, 2024
@mesonepigreco mesonepigreco self-requested a review February 7, 2024 11:29
Copy link
Collaborator

@mesonepigreco mesonepigreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimal change is indeed good, as it updates the version of the SSSP library for the pseudopotential to the latest one.

As this is on a test, it does not affect the code execution, but only the correctness of the test workflow

@mesonepigreco mesonepigreco merged commit a708d2e into SSCHAcode:master Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning cleaning of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants