Roles dns mgmt

[danlavu]

No description provided.

[danlavu]

#197 This PR was going to include the IP utilities but that has since been moved. Removing @thalman as a reviewer in the interim.

The IP utilities has been moved to #197, this PR should only pertain to DNS.

[danlavu]

Okay, this is ready for review again.

output, the output is from a slightly older run, they may be some minor inconsistencies. Please this PR should be tested by the reviewer.

PASSED                      [  3%]['_msdcs.ad.test', '0.in-addr.arpa', '127.in-addr.arpa', '255.in-addr.arpa', 'ad.test', 'example.com']
PASSED                  [  6%]['_msdcs.ad.test', '0.in-addr.arpa', '1.168.192.in-addr.arpa', '127.in-addr.arpa', '255.in-addr.arpa', 'ad.test']
PASSED            [  9%]['fec0:0:0:ffff::3', ' fec0:0:0:ffff::2', ' fec0:0:0:ffff::1', ' 192.168.121.1']
PASSED [ 12%]add ['1.1.1.1', ' fec0:0:0:ffff::3', ' fec0:0:0:ffff::2', ' fec0:0:0:ffff::1']
remove ['192.168.121.1', ' fec0:0:0:ffff::3', ' fec0:0:0:ffff::2', ' fec0:0:0:ffff::1']
add ['1.1.1.1', ' 192.168.121.1', ' fec0:0:0:ffff::3', ' fec0:0:0:ffff::2']
PASSED          [ 16%]['fec0:0:0:ffff::3', ' fec0:0:0:ffff::2', ' fec0:0:0:ffff::1', ' 192.168.121.1']
['']
PASSED              [ 19%]
PASSED                  [ 22%]
PASSED            [ 25%]{'name': 'sssd.io.', 'type': 'A', 'ttl': 2363, 'data': '104.17.33.82', 'all_data': [{...}]}
PASSED [ 29%]name:  sssd.io.
PASSED [ 32%]type:  A
PASSED [ 35%]ttl:  2350
PASSED [ 38%]data:  104.17.33.82
PASSED [ 41%]all_data:  [{'name': 'sssd.io.', 'type': 'A', 'ttl': 2342, 'data': '104.17.33.82', 'all_data': [...]}]
PASSED [ 45%]{'name': 'www.redhat.com.', 'type': 'CNAME', 'ttl': 3299, 'data': 'ds-www.redhat.com.edgekey.net.'}
PASSED [ 48%]{'name': 'sssd.io.', 'type': 'A', 'ttl': 2361, 'data': '104.17.33.82', 'all_data': [{...}]}
PASSED            [ 51%]{'name': '87.87.86.104.in-addr.arpa.', 'type': 'PTR', 'ttl': 25409, 'data': 'a104-86-87-87.deploy.static.akamaitechnologies.com.', 'all_data': [{...}]}
PASSED [ 54%]None
PASSED                     [ 58%]['251.255.10.in-addr.arpa', '100.16.172.in-addr.arpa', 'example.com', 'ipa.test']
PASSED                 [ 61%]['251.255.10.in-addr.arpa', '100.16.172.in-addr.arpa', '1.168.192.in-addr.arpa', 'ipa.test']
PASSED           [ 64%]None
PASSED [ 67%]add ['1.1.1.1']
remove None
add ['1.1.1.1']
PASSED         [ 70%]None
None
PASSED             [ 74%]
PASSED                 [ 77%]
PASSED                   [ 80%]['example.com', 'samba.test', '_msdcs.samba.test']
PASSED               [ 83%]['1.168.192.in-addr.arpa', 'samba.test', '_msdcs.samba.test']
PASSED         [ 87%]['172.16.100.1']
PASSED [ 90%]add ['172.16.100.1', '1.1.1.1']
remove ['172.16.100.1']
add ['172.16.100.1', '1.1.1.1']
PASSED       [ 93%]['172.16.100.1']
['']
PASSED           [ 96%]
PASSED               [100%]

test code

from __future__ import annotations

import pytest
from sssd_test_framework.roles.client import Client
from sssd_test_framework.roles.ipa import IPA
from sssd_test_framework.roles.ad import AD
from sssd_test_framework.roles.samba import Samba
from sssd_test_framework.roles.generic import GenericProvider
from sssd_test_framework.topology import KnownTopology, KnownTopologyGroup

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_create_zone(provider: GenericProvider):
    provider.dns().zone("example.com").create()
    print(provider.dns().list_zones())

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_create_ptr_zone(provider: GenericProvider):
    provider.dns().zone("1.168.192.in-addr.arpa").create()
    print(provider.dns().list_zones())

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_get_global_forwarders(provider: GenericProvider):
    print(provider.dns().get_forwarders())

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_add_and_remove_global_forwarders(provider: GenericProvider):
    provider.dns().add_forwarder("1.1.1.1")
    print("add", provider.dns().get_forwarders())
    provider.dns().remove_forwarder("1.1.1.1")
    print("remove", provider.dns().get_forwarders())
    provider.dns().add_forwarder("1.1.1.1")
    print("add", provider.dns().get_forwarders())

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_clear_global_forwarders(provider: GenericProvider):
    print(provider.dns().get_forwarders())
    provider.dns().clear_forwarders()
    print(provider.dns().get_forwarders())

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_add_forward_records(provider: GenericProvider):
    provider.dns().zone(provider.domain).add_record("test_a_record", "1.2.3.4")

@pytest.mark.topology(KnownTopologyGroup.AnyDC)
def test_dns_add_records(provider: GenericProvider):
    ptr_zone = provider.dns().zone("1.168.192.in-addr.arpa").create()
    ptr_zone.add_record(f"test_a_record.{provider.domain}", 15)

@pytest.mark.topology(KnownTopology.AD)
def test_dig_forward_record_lookup(client: Client, provider: GenericProvider):
    print(client.net.dig("sssd.io"))

@pytest.mark.parametrize("key", ["name", "type", "ttl", "data", "all_data"])
@pytest.mark.topology(KnownTopology.AD)
def test_dig_forward_record_lookup_get_attr(client: Client, provider: GenericProvider, key: str):
    result = client.net.dig("sssd.io")
    print(f"{key}: ", result.get(key))

@pytest.mark.topology(KnownTopology.AD)
def test_dig_forward_record_lookup_with_multiple_records(client:Client, provider: GenericProvider):
    print(client.net.dig("www.redhat.com"))

@pytest.mark.topology(KnownTopology.AD)
def test_dig_forward_record_lookup_with_server_specified(client: Client, provider: GenericProvider):
    print(client.net.dig("sssd.io", server="192.168.50.2"))

@pytest.mark.topology(KnownTopology.AD)
def test_dig_reverse_record_lookup(client: Client, provider: GenericProvider):
    print(client.net.dig("104.86.87.87", reverse = True))

@pytest.mark.topology(KnownTopology.AD)
def test_dig_forward_record_lookup_bad_record(client: Client, provider: GenericProvider):
    print(client.net.dig("ssssssssssssssssssssd.io"))

[jakub-vavra-cz]

LGTM

[justin-stephenson]

Can you rebase to include commit from #202 ? It should trigger a SSSD run of system tests, to ensure there is no breakage.

[danlavu]

@justin-stephenson done.

[justin-stephenson]

@justin-stephenson done.

Once CI completes I will ack.

[justin-stephenson]

Ack, thank you.

[jakub-vavra-cz]

LGTM