Skip to content

Conversation

@K-ballo
Copy link
Member

@K-ballo K-ballo commented Aug 7, 2025

No description provided.

@K-ballo K-ballo requested a review from hkaiser August 7, 2025 09:16
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@K-ballo
Copy link
Member Author

K-ballo commented Aug 26, 2025

The mere construction of a fork-join executor prevents other executors from making progress.

@K-ballo K-ballo force-pushed the fork_join_executor branch from a2db469 to 2175af8 Compare August 29, 2025 13:22
@hkaiser
Copy link
Member

hkaiser commented Sep 17, 2025

The mere construction of a fork-join executor prevents other executors from making progress.

Yes, that's a 'feature' and not a bug ;-)

@K-ballo
Copy link
Member Author

K-ballo commented Sep 20, 2025

The mere construction of a fork-join executor prevents other executors from making progress.

Yes, that's a 'feature' and not a bug ;-)

In that case any choice of executor should be removed entirely from the backend, as it will always lead to incorrect programs.

@hkaiser
Copy link
Member

hkaiser commented Sep 20, 2025

The mere construction of a fork-join executor prevents other executors from making progress.

Yes, that's a 'feature' and not a bug ;-)

In that case any choice of executor should be removed entirely from the backend, as it will always lead to incorrect programs.

If there is a way to customize the executor in the benchmark without adding it to the backend itself - sure, I'd agree.

@K-ballo
Copy link
Member Author

K-ballo commented Sep 20, 2025

This PR makes the fork_join_executor the default executor, not the only possible executor. When explicit policies are used, execution happens on the executor specified by the policy. Those executions can never progress since a fork_join_executor has been constructed. That's the reason this PR is still a draft: it does not work.

For things to work, the fork_join_executor has to be the only executor in the system.

If there is a way to customize the executor in the benchmark without adding it to the backend itself - sure, I'd agree.

I'm not aware of such a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants