-
Notifications
You must be signed in to change notification settings - Fork 2
Use fork_join_executor by default #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
The mere construction of a fork-join executor prevents other executors from making progress. |
a2db469 to
2175af8
Compare
Yes, that's a 'feature' and not a bug ;-) |
In that case any choice of executor should be removed entirely from the backend, as it will always lead to incorrect programs. |
If there is a way to customize the executor in the benchmark without adding it to the backend itself - sure, I'd agree. |
|
This PR makes the For things to work, the
I'm not aware of such a way. |
No description provided.