Skip to content

Conversation

@isidorostsa
Copy link
Contributor

@isidorostsa isidorostsa commented May 17, 2025

P2300 has moved away from the tag_invoke design pattern, following the guidance in P2855. This PR removes tag_invoke support from the P2300 CPOs used by our senders. However, sender-adapter CPOs can remain tag_invoke-friendly since they provide an operator() that internally calls tag_invoke. For example, when_all_vector must drop support for tag_invoke(set_value_t...), but the when_all_vector algorithm itself can still be implemented as a CPO using operator() that calls tag_invoke(when_all_vector_t) under the hood.

At present, the non-stdexec implementation of senders will not be updated to work without tag_invoke.

@isidorostsa isidorostsa requested a review from hkaiser as a code owner May 17, 2025 06:54
@hkaiser hkaiser added this to the 2.0.0 milestone May 17, 2025
@hkaiser hkaiser added the category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals label May 17, 2025
@isidorostsa isidorostsa force-pushed the sr-tag_inv-to-mem-functions branch from c7b0044 to d8a5414 Compare May 19, 2025 14:29
@isidorostsa isidorostsa force-pushed the sr-tag_inv-to-mem-functions branch from d8a5414 to 4561a4c Compare June 10, 2025 13:05
@isidorostsa isidorostsa force-pushed the sr-tag_inv-to-mem-functions branch from 4561a4c to ea93afb Compare June 10, 2025 13:50
@isidorostsa isidorostsa reopened this Jun 10, 2025
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ea93afb1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ea93afb) Report Missing Report Missing Report Missing
Head commit (010d56c) 194788 164979 84.70%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6709) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants