Skip to content

Conversation

@sususu5
Copy link
Contributor

@sususu5 sususu5 commented Jun 13, 2025

Fixes #

Proposed Changes

  • Add scheduler-specific implementation for the parallel version of nth_element algorithm
  • Unit test from last year's GSoC project is added and passes
  • A line testing forward iterator on nth_element is removed from the test case because it does not conform to the C++ standard

Any background context you want to provide?

URL of the removed line in unit test

nth_element_sender_test<std::forward_iterator_tag>();

Checklist

Not all points below apply to all pull requests.

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.
  • I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

@sususu5 sususu5 requested a review from hkaiser as a code owner June 13, 2025 04:51
@StellarBot
Copy link

Can one of the admins verify this patch?

@codacy-production
Copy link

codacy-production bot commented Jun 13, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.70% 77.42%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (15afc8b) 244963 210174 85.80%
Head commit (330b2ea) 193840 (-51123) 164950 (-45224) 85.10% (-0.70%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6720) 31 24 77.42%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@sususu5 sususu5 force-pushed the fix-sr-nth_element branch from c13ac23 to 330b2ea Compare June 18, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants