Integrate NVIDIA's S/R Bulk implementation into HPX #6746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exception_list class in the hpx namespace is a thread-safe container for handling multiple exceptions encountered during parallel algorithm execution. It allows storing std::exception_ptr objects, provides thread-safe access via a spinlock, and includes methods to add exceptions, get the count (size()), and iterate over the stored exceptions (begin()/end()). The class also includes placeholders for retrieving error codes and messages. This is useful for collecting and managing exceptions across parallel threads.
|
Can one of the admins verify this patch? |
charan-003
changed the title
hkaiser
added
type: enhancement
category: senders/receivers
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
charan-003
force-pushed
the
feature/forward-bulk
branch
from
49b7122 to
ff8a35c
Compare
isidorostsa
reviewed
Aug 15, 2025
Contributor
isidorostsa
left a comment
isidorostsa
left a comment
There was a problem hiding this comment.
Excellent work! The tests are checking all the correct things, so if we get them passing we are good to merge :)
libs/core/execution_base/include/hpx/execution_base/stdexec_forward.hpp
Outdated
Show resolved
Hide resolved
libs/core/executors/include/hpx/executors/explicit_scheduler_executor.hpp
Outdated
Show resolved
Hide resolved
libs/core/executors/include/hpx/executors/explicit_scheduler_executor.hpp
Outdated
Show resolved
Hide resolved
libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp
Outdated
Show resolved
Hide resolved
libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp
Outdated
Show resolved
Hide resolved
charan-003
force-pushed
the
feature/forward-bulk
branch
6 times, most recently
from
bf43519 to
15f19e6
Compare
charan-003
force-pushed
the
feature/forward-bulk
branch
2 times, most recently
from
1a7c336 to
d8a6edc
Compare
charan-003
force-pushed
the
feature/forward-bulk
branch
from
704d766 to
862697f
Compare
charan-003
force-pushed
the
feature/forward-bulk
branch
from
38f9415 to
ded57a3
Compare
added 2 commits
December 2, 2025 02:59
charan-003
force-pushed
the
feature/forward-bulk
branch
from
6e97b1b to
19bdc0d
Compare
Contributor
Author
|
@hkaiser @isidorostsa just a small ping on this PR. Could you please take a look when you have a moment and let me know if anything else is needed? |
charan-003
force-pushed
the
feature/forward-bulk
branch
from
30822d0 to
a9a1945
Compare
charan-003
force-pushed
the
feature/forward-bulk
branch
from
a355911 to
28c6c90
Compare
charan-003
force-pushed
the
feature/forward-bulk
branch
from
ae24683 to
c8166c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards stdexec::bulk and stdexec::bulk_t inside stdexec_forward.hpp.
These were previously commented out. This change makes bulk available through hpx::execution::experimental::bulk, aligning HPX's Sender/Receiver interface with NVIDIA's stdexec implementation.