Integrate NVIDIA's S/R Bulk implementation into HPX #6746

charan-003 · 2025-07-18T17:58:00Z

This PR forwards stdexec::bulk and stdexec::bulk_t inside stdexec_forward.hpp.

These were previously commented out. This change makes bulk available through hpx::execution::experimental::bulk, aligning HPX's Sender/Receiver interface with NVIDIA's stdexec implementation.

StellarBot · 2025-07-18T18:00:02Z

Can one of the admins verify this patch?

codacy-production · 2025-08-02T06:19:03Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `c0dab02`¹	✅ 94.31%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`c0dab02`)	Report Missing	Report Missing	Report Missing
Head commit (`e38f0a4`)	209806	175886	83.83%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6746)	211	199	94.31%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp

isidorostsa

Excellent work! The tests are checking all the correct things, so if we get them passing we are good to merge :)

libs/core/execution/include/hpx/execution/algorithms/bulk.hpp

libs/core/execution_base/include/hpx/execution_base/stdexec_forward.hpp

libs/core/executors/include/hpx/executors/explicit_scheduler_executor.hpp

libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp

isidorostsa

Really great work!

isidorostsa · 2025-09-17T15:04:52Z

libs/core/algorithms/include/hpx/parallel/container_algorithms/for_each.hpp

Let's remove those files from this PR as they are being worked on for the same reason by another contributor

isidorostsa · 2025-09-17T15:08:15Z

libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp

Changes here are not important

isidorostsa · 2025-09-17T15:11:59Z

libs/core/execution_base/include/hpx/execution_base/stdexec_forward.hpp

    // Continue on
    using stdexec::continue_on;
    using stdexec::continue_on_t;
+    // Backward compatibility alias for continues_on


No need to have backwards compatibility here, you can remove 134-138

isidorostsa · 2025-09-17T15:13:26Z

libs/core/execution_base/include/hpx/execution_base/stdexec_forward.hpp

+
+    // Additional stdexec concepts and utilities needed for domain customization
+    using stdexec::__completes_on;
+    using stdexec::__starts_on;


__completes_on, __starts_on, and sender_expr_for should be moved in the stdexec internals namespace

isidorostsa · 2025-09-17T15:18:12Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp

+    // Concept to match bulk sender types
+    // Note: We keep bulk_t handling as pragmatic workaround for stdexec template issues
+    template <typename Sender>
+    concept any_bulk_sender =


should be renamed to bulk_chunked_or_unchunked_sender

isidorostsa · 2025-09-17T15:34:50Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

+    constexpr void bulk_scheduler_invoke_helper_chunked(
+        hpx::util::index_pack<Is...>, F&& f, Start&& start, End&& end, Ts& ts)
+    {
+        if constexpr (sizeof...(Is) == 0)


We can remove the sizeof...(Is) == 0 test here

isidorostsa · 2025-09-17T15:36:54Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp


-            auto it = std::next(hpx::util::begin(op_state->shape), i_begin);
-            for (std::uint32_t i = i_begin; i != i_end; (void) ++it, ++i)
+            auto it =


this should be moved inside the else branch below

isidorostsa · 2025-09-17T15:37:59Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

        {
            // Don't spawn tasks if there is no work to be done
            auto const size =
+                // static_cast<std::uint32_t>(op_state->shape);


we can remove this commented out part

isidorostsa · 2025-09-17T15:38:57Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

-                hpx::is_invocable_v<F, range_value_type,
-                    std::add_lvalue_reference_t<Ts>...>
-            )>
+        template <typename... Ts>


We should re-add the test as a normal concept (requires) clause

isidorostsa · 2025-09-17T15:40:34Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

    };
 }    // namespace hpx::execution::experimental::detail

-namespace hpx::execution::experimental {


Better wrap this in an #if !defined clause instead of removing, so we keep backwards compatibility for now

isidorostsa · 2025-09-17T17:05:19Z

libs/core/execution_base/include/hpx/execution_base/stdexec_forward.hpp

    using stdexec::on_t;

    // Continue on
    using stdexec::continue_on;


This (134, 135) should be removed too, since the proper spelling is continues_on

This reverts commit e9685b2.

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

isidorostsa · 2025-10-02T14:29:14Z

libs/core/executors/include/hpx/executors/thread_pool_scheduler_bulk.hpp

 #include <hpx/coroutines/thread_enums.hpp>
 #include <hpx/datastructures/tuple.hpp>
 #include <hpx/datastructures/variant.hpp>
-#include <hpx/execution/algorithms/bulk.hpp>


This should be included in the headers when not using STDEXEC, it seems this is what's causing this failing test:

https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/18789/workflows/d6fb3490-5f5a-4b18-8cef-730ffef44797/jobs/427793

updated algorithm_bulk test file

3e13add

charan-003 requested a review from hkaiser as a code owner July 18, 2025 17:58

updated thread_pool_bulk

d62a019

charan-003 changed the title ~~updated algorithm_bulk test file~~ Integrate NVIDIA's S/R Bulk implementation into HPX Jul 23, 2025

hkaiser added type: enhancement category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals project: GSoC labels Jul 25, 2025

implementing stdexec bulk in thread pool scheduler bulk v1

1435011

charan-003 marked this pull request as draft August 2, 2025 06:10

charan-003 added 5 commits August 2, 2025 00:27

implementing stdexec bulk in thread pool scheduler bulk v2

e359e65

implementing stdexec bulk in thread pool scheduler bulk v3

5c16588

changing tag invoke to domain

b134e03

changing tag invoke to domain v2

4b1074b

changing tag invoke to domain v3

c3fcbda

github-advanced-security bot found potential problems Aug 7, 2025

View reviewed changes

libs/core/executors/include/hpx/executors/thread_pool_scheduler.hpp Fixed Show fixed Hide fixed

charan-003 and others added 5 commits August 10, 2025 01:35

implementing stdexec bulk and domain v1

9e6fe4a

clean up header dependencies

dfedfc8

HPX thread pool with domain-based customization

b12bfb3

Merge branch 'STEllAR-GROUP:master' into feature/forward-bulk

cae2eb4

fixing minor errrors v1

ff8a35c

charan-003 force-pushed the feature/forward-bulk branch from 49b7122 to ff8a35c Compare August 13, 2025 19:00

Sai Charan added 4 commits August 13, 2025 16:30

fixing errors 1

e2de597

fixing minor errrors v2

75409da

fixing minor errrors v2.1

e30e63f

fixing minor errrors v3

8c920f3

isidorostsa reviewed Aug 15, 2025

View reviewed changes

Sai Charan added 2 commits August 15, 2025 15:00

keeping back the old version

0448223

keeping back the old version v1

cd232b3

charan-003 requested a review from isidorostsa September 11, 2025 06:53

isidorostsa reviewed Sep 13, 2025

View reviewed changes

Sai Charan and others added 5 commits September 13, 2025 20:42

detect bulk as default implementation to bulk chunked

3119ef4

Merge branch 'master' into feature/forward-bulk

f3fc6fa

revert back bulk_t

6ada3c8

bulk_chunked uses f(start,end,...)

6a8fb0e

remove bulk_t

13b291e

isidorostsa previously approved these changes Sep 16, 2025

View reviewed changes

formatting

e9eefdd

charan-003 dismissed isidorostsa’s stale review via e9eefdd September 16, 2025 16:12

formatting fix

c8e8d9c

isidorostsa marked this pull request as ready for review September 16, 2025 16:48

formatting fix arrow

2f9b3b5

isidorostsa previously approved these changes Sep 17, 2025

View reviewed changes

minor fix

b18a39a

charan-003 dismissed isidorostsa’s stale review via b18a39a September 17, 2025 16:40

isidorostsa reviewed Sep 17, 2025

View reviewed changes

Sai Charan and others added 4 commits September 17, 2025 12:41

removing continue on

a568202

format

36ae7f4

Concept Check set_value got correct F

e9685b2

Revert "Concept Check set_value got correct F"

ab206b1

This reverts commit e9685b2.

isidorostsa reviewed Oct 1, 2025

View reviewed changes

old implementation of bulk

79f731c

isidorostsa reviewed Oct 2, 2025

View reviewed changes

Sai Charan and others added 2 commits October 2, 2025 17:55

include header

ee410cf

Merge branch 'master' into feature/forward-bulk

e38f0a4

charan-003 requested review from isidorostsa October 9, 2025 17:53

Uh oh!

Integrate NVIDIA's S/R Bulk implementation into HPX #6746

Are you sure you want to change the base?

Integrate NVIDIA's S/R Bulk implementation into HPX #6746

Conversation

charan-003 commented Jul 18, 2025

Uh oh!

StellarBot commented Jul 18, 2025

Uh oh!

codacy-production bot commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

Footnotes

Uh oh!

Uh oh!

isidorostsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isidorostsa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isidorostsa Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codacy-production bot commented Aug 2, 2025 •

edited

Loading

isidorostsa Oct 2, 2025 •

edited

Loading