Skip to content

Adapting HPX Modules hash, datastructures, and memory to C++ modules #6783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adapting HPX Modules hash, datastructures, and memory to C++ modules #6783

wants to merge 2 commits into from
+2,378 −2,361

Conversation

@hkaiser
Copy link
Member

@hkaiser hkaiser commented Sep 28, 2025

No description provided.

@hkaiser hkaiser added this to the 2.0.0 milestone Sep 28, 2025
@hkaiser hkaiser force-pushed the hash_datastructures_memory branch 3 times, most recently from ace0abf to 9ccc352 Compare September 28, 2025 15:15
@codacy-production
Copy link

codacy-production bot commented Sep 28, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -2.07% ✅ 67.09%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (afcbb5b) 273067 235146 86.11%
Head commit (6a00059) 197645 (-75422) 166099 (-69047) 84.04% (-2.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6783) 632 424 67.09%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@hkaiser hkaiser force-pushed the hash_datastructures_memory branch 2 times, most recently from 079230e to b8273eb Compare September 28, 2025 22:34
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-08-24T21:58:54+00:002025-09-28T22:34:54+00:00
HPX Commit501a585f6f7e0e
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2025-08-24T17:06:08.105484-05:002025-09-28T17:40:25.293336-05:00
Clusternamerostamrostam

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
HPX Datetime2025-08-24T21:58:54+00:002025-09-28T22:34:54+00:00
HPX Commit501a585f6f7e0e
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2025-08-24T17:08:02.398682-05:002025-09-28T17:42:16.533623-05:00
Clusternamerostamrostam

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)=
Stream Benchmark - Triad(=)-(=)
Stream Benchmark - Copy+-+

Info

PropertyBeforeAfter
HPX Datetime2025-08-24T21:58:54+00:002025-09-28T22:34:54+00:00
HPX Commit501a585f6f7e0e
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2025-08-24T17:08:22.660177-05:002025-09-28T17:42:36.659898-05:00
Clusternamerostamrostam

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser force-pushed the hash_datastructures_memory branch from b8273eb to 9df1ed7 Compare October 1, 2025 22:32
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-08-24T21:58:54+00:002025-10-01T22:32:28+00:00
HPX Commit501a58503c13ab
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2025-08-24T17:06:08.105484-05:002025-10-01T17:41:06.181691-05:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
HPX Datetime2025-08-24T21:58:54+00:002025-10-01T22:32:28+00:00
HPX Commit501a58503c13ab
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2025-08-24T17:08:02.398682-05:002025-10-01T17:42:57.676614-05:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)=
Stream Benchmark - Triad=-(=)
Stream Benchmark - Copy+-+

Info

PropertyBeforeAfter
HPX Datetime2025-08-24T21:58:54+00:002025-10-01T22:32:28+00:00
HPX Commit501a58503c13ab
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2025-08-24T17:08:22.660177-05:002025-10-01T17:43:17.871883-05:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser force-pushed the hash_datastructures_memory branch from 9df1ed7 to a27a17e Compare October 2, 2025 02:28
@hkaiser hkaiser changed the title Hash datastructures memory Adapting HPX Modules hash, datastructures, and memory to C++ modules Oct 20, 2025
@hkaiser hkaiser force-pushed the hash_datastructures_memory branch 13 times, most recently from 429b9b7 to 3c0ea30 Compare October 21, 2025 18:07
@hkaiser hkaiser force-pushed the hash_datastructures_memory branch 5 times, most recently from 0315c58 to be9b22d Compare October 21, 2025 22:59
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2025
View reviewed changes
@hkaiser hkaiser force-pushed the hash_datastructures_memory branch 2 times, most recently from ef6f27d to 162b80f Compare October 22, 2025 18:05
@hkaiser
Adjust module interface file extension for different compilers
6a00059 
- flyby: build HPX full using C++ modules from HPX core
- flyby: modify CMake build system to properly propagate C++ module settings
- flyby: fixed a couple of problems with existing C++ module integration

Signed-off-by: Hartmut Kaiser <[email protected]>
@hkaiser hkaiser force-pushed the hash_datastructures_memory branch from 162b80f to 6a00059 Compare October 22, 2025 19:15
@hkaiser
Copy link
Member Author

hkaiser commented Oct 23, 2025

retest lsu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

category: CMake category: modules type: compatibility issue type: enhancement

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hkaiser @StellarBot