Skip to content

Conversation

@the-ivii
Copy link
Contributor

@the-ivii the-ivii commented Feb 4, 2026

Fixes #6874

Proposed Changes

  • i fixed 1d_stencil_5 crash by implementing the missing serialization logic for partition_data,which was previously empty and this ensures the data is correctly packed and transmitted during HPX actions, preventing the system from crashing on invalid empty objects.

Any background context you want to provide?

Checklist

Not all points below apply to all pull requests.

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.
  • I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

@the-ivii the-ivii requested a review from hkaiser as a code owner February 4, 2026 04:31
@the-ivii the-ivii force-pushed the fix/issue-6874-1d_stencil_5-serialization branch from 692b8c4 to 38cd646 Compare February 4, 2026 04:34
@StellarBot
Copy link

Can one of the admins verify this patch?

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is not actually needed for this example, it doesn't hurt to have the serialization implemented as a guideline for people on how to do that.

LGTM, thanks!

@hkaiser hkaiser merged commit f36e02d into STEllAR-GROUP:master Feb 4, 2026
69 of 75 checks passed
@hkaiser
Copy link
Member

hkaiser commented Feb 4, 2026

@the-ivii thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.examples.1d_stencil.1d_stencil_5 is failing in some CI runs

3 participants