feat: add hub-spoke ACL policy for privileged networks

cmd/wonder/commands/coordinator.go

@@ -3,6 +3,7 @@ package commands
 import (
 	"log/slog"
 	"os"
+	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
@@ -44,6 +45,7 @@ func NewCoordinatorCmd() *cobra.Command {
 	_ = viper.BindEnv("coordinator.keycloak_client_secret", "KEYCLOAK_CLIENT_SECRET")
 	_ = viper.BindEnv("coordinator.enable_admin_api", "ENABLE_ADMIN_API")
 	_ = viper.BindEnv("coordinator.admin_api_auth_token", "ADMIN_API_AUTH_TOKEN")
+	_ = viper.BindEnv("coordinator.privileged_networks", "PRIVILEGED_NETWORKS")
 
 	return cmd
 }
@@ -66,6 +68,15 @@ func runCoordinator(cmd *cobra.Command, args []string) {
 	cfg.EnableAdminAPI = viper.GetBool("coordinator.enable_admin_api")
 	cfg.AdminAPIAuthToken = viper.GetString("coordinator.admin_api_auth_token")
 
+	if networks := viper.GetString("coordinator.privileged_networks"); networks != "" {
+		for _, n := range strings.Split(networks, ",") {
+			n = strings.TrimSpace(n)
+			if n != "" {
+				cfg.PrivilegedNetworks = append(cfg.PrivilegedNetworks, n)
+			}
+		}
+	}
+
 	if cfg.HeadscaleURL == "" {
 		cfg.HeadscaleURL = coordinator.DefaultHeadscaleURL
 	}
@@ -101,6 +112,10 @@ func runCoordinator(cmd *cobra.Command, args []string) {
 		slog.Info("admin API enabled")
 	}
 
+	if len(cfg.PrivilegedNetworks) > 0 {
+		slog.Info("privileged networks configured", "networks", cfg.PrivilegedNetworks)
+	}
+
 	server, err := coordinator.BootstrapNewServer(&cfg)
 	if err != nil {
 		slog.Error("create server", "error", err)

internal/app/coordinator/config.go

@@ -33,6 +33,10 @@ type Config struct {
 	// AdminAPIAuthToken is the bearer token for admin API authentication.
 	// Required if EnableAdminAPI is true. Must be at least 32 characters.
 	AdminAPIAuthToken string `mapstructure:"admin_api_auth_token"`
+
+	// PrivilegedNetworks is the list of Headscale usernames that have access to all
+	// WonderNets (hub-spoke ACL model). When empty, pure isolation policy is used.
+	PrivilegedNetworks []string
 }
 
 const (

internal/app/coordinator/server.go

@@ -114,7 +114,7 @@ func BootstrapNewServer(config *Config) (*Server, error) {
 	meshBackend := tailscale.NewTailscaleMesh(headscaleClient, config.PublicURL)
 
 	// Create services
-	wonderNetService := service.NewWonderNetService(wonderNetRepository, wonderNetManager, aclManager, config.PublicURL)
+	wonderNetService := service.NewWonderNetService(wonderNetRepository, wonderNetManager, aclManager, config.PublicURL, config.PrivilegedNetworks)
 	workerService := service.NewWorkerService(tokenGenerator, config.JWTSecret, wonderNetRepository, meshBackend)
 	nodesService := service.NewNodesService(meshBackend)
 	apiKeyService := service.NewAPIKeyService(apiKeyRepository, wonderNetRepository)

internal/app/coordinator/service/wondernet.go

@@ -23,6 +23,7 @@ type WonderNetService struct {
 	wonderNetManager    *headscale.WonderNetManager
 	aclManager          *headscale.ACLManager
 	publicURL           string
+	privilegedNetworks  []string
 }
 
 // NewWonderNetService creates a new WonderNetService.
@@ -31,12 +32,14 @@ func NewWonderNetService(
 	wonderNetManager *headscale.WonderNetManager,
 	aclManager *headscale.ACLManager,
 	publicURL string,
+	privilegedNetworks []string,
 ) *WonderNetService {
 	return &WonderNetService{
 		wonderNetRepository: wonderNetRepository,
 		wonderNetManager:    wonderNetManager,
 		aclManager:          aclManager,
 		publicURL:           publicURL,
+		privilegedNetworks:  privilegedNetworks,
 	}
 }
 
@@ -93,8 +96,13 @@ func (s *WonderNetService) GetPublicURL() string {
 	return s.publicURL
 }
 
-// InitializeACLPolicy rebuilds the ACL policy from all existing WonderNets to enforce isolation.
+// InitializeACLPolicy rebuilds the full ACL policy from all existing Headscale users.
+// When a privileged network is configured, a hub-spoke policy is used;
+// otherwise, pure isolation policy is applied.
 func (s *WonderNetService) InitializeACLPolicy(ctx context.Context) error {
+	if len(s.privilegedNetworks) > 0 {
+		return s.aclManager.SetHubSpokePolicy(ctx, s.privilegedNetworks)
+	}
 	return s.aclManager.SetWonderNetIsolationPolicy(ctx)
 }
 

pkg/headscale/acl.go

@@ -41,6 +41,38 @@ func GenerateWonderNetIsolationPolicy(usernames []string) *ACLPolicy {
 	}
 }
 
+// GenerateHubSpokePolicy generates an ACL policy where privileged namespaces
+// can access all nodes, and all nodes can reply to them, while normal namespaces
+// are isolated from each other.
+func GenerateHubSpokePolicy(privilegedUsers []string, normalUsers []string) *ACLPolicy {
+	rules := make([]ACLRule, 0, 2*len(privilegedUsers)+len(normalUsers))
+
+	for _, user := range privilegedUsers {
+		rules = append(rules,
+			ACLRule{
+				Action:       "accept",
+				Sources:      []string{user + "@"},
+				Destinations: []string{"*:*"},
+			},
+			ACLRule{
+				Action:       "accept",
+				Sources:      []string{"*"},
+				Destinations: []string{user + "@:*"},
+			},
+		)
+	}
+
+	for _, username := range normalUsers {
+		rules = append(rules, ACLRule{
+			Action:       "accept",
+			Sources:      []string{username + "@"},
+			Destinations: []string{username + "@:*"},
+		})
+	}
+
+	return &ACLPolicy{ACLs: rules}
+}
+
 // ACLManager manages ACL policies in Headscale
 type ACLManager struct {
 	client v1.HeadscaleServiceClient
@@ -78,6 +110,40 @@ func (am *ACLManager) SetWonderNetIsolationPolicy(ctx context.Context) error {
 	return err
 }
 
+// SetHubSpokePolicy sets an ACL policy where privileged namespaces can access
+// all nodes while normal namespaces are isolated from each other.
+func (am *ACLManager) SetHubSpokePolicy(ctx context.Context, privilegedUsers []string) error {
+	am.mu.Lock()
+	defer am.mu.Unlock()
+
+	resp, err := am.client.ListUsers(ctx, &v1.ListUsersRequest{})
+	if err != nil {
+		return fmt.Errorf("list users: %w", err)
+	}
+
+	privilegedSet := make(map[string]struct{}, len(privilegedUsers))
+	for _, u := range privilegedUsers {
+		privilegedSet[u] = struct{}{}
+	}
+
+	var normalUsers []string
+	for _, u := range resp.GetUsers() {
+		name := u.GetName()
+		if _, ok := privilegedSet[name]; !ok {
+			normalUsers = append(normalUsers, name)
+		}
+	}
+
+	policy := GenerateHubSpokePolicy(privilegedUsers, normalUsers)
+	policyJSON, err := json.Marshal(policy)
+	if err != nil {
+		return fmt.Errorf("marshal policy: %w", err)
+	}
+
+	_, err = am.client.SetPolicy(ctx, &v1.SetPolicyRequest{Policy: string(policyJSON)})
+	return err
+}
+
 // AddWonderNetToPolicy adds a wonder net to the isolation policy
 func (am *ACLManager) AddWonderNetToPolicy(ctx context.Context, username string) error {
 	am.mu.Lock()

pkg/headscale/acl_test.go

@@ -0,0 +1,81 @@
+package headscale
+
+import (
+	"testing"
+)
+
+func TestGenerateWonderNetIsolationPolicy(t *testing.T) {
+	policy := GenerateWonderNetIsolationPolicy([]string{"user1", "user2"})
+
+	if len(policy.ACLs) != 2 {
+		t.Fatalf("expected 2 rules, got %d", len(policy.ACLs))
+	}
+
+	assertRule(t, policy.ACLs[0], "accept", []string{"user1@"}, []string{"user1@:*"})
+	assertRule(t, policy.ACLs[1], "accept", []string{"user2@"}, []string{"user2@:*"})
+}
+
+func TestGenerateHubSpokePolicy(t *testing.T) {
+	policy := GenerateHubSpokePolicy([]string{"zeabur"}, []string{"uuid1", "uuid2"})
+
+	// 2 rules for privileged (outbound + inbound) + 2 rules for normal users
+	if len(policy.ACLs) != 4 {
+		t.Fatalf("expected 4 rules, got %d", len(policy.ACLs))
+	}
+
+	assertRule(t, policy.ACLs[0], "accept", []string{"zeabur@"}, []string{"*:*"})
+	assertRule(t, policy.ACLs[1], "accept", []string{"*"}, []string{"zeabur@:*"})
+	assertRule(t, policy.ACLs[2], "accept", []string{"uuid1@"}, []string{"uuid1@:*"})
+	assertRule(t, policy.ACLs[3], "accept", []string{"uuid2@"}, []string{"uuid2@:*"})
+}
+
+func TestGenerateHubSpokePolicy_MultiplePrivileged(t *testing.T) {
+	policy := GenerateHubSpokePolicy([]string{"zeabur", "admin"}, []string{"uuid1"})
+
+	// 2 rules per privileged user (2*2=4) + 1 normal user
+	if len(policy.ACLs) != 5 {
+		t.Fatalf("expected 5 rules, got %d", len(policy.ACLs))
+	}
+
+	assertRule(t, policy.ACLs[0], "accept", []string{"zeabur@"}, []string{"*:*"})
+	assertRule(t, policy.ACLs[1], "accept", []string{"*"}, []string{"zeabur@:*"})
+	assertRule(t, policy.ACLs[2], "accept", []string{"admin@"}, []string{"*:*"})
+	assertRule(t, policy.ACLs[3], "accept", []string{"*"}, []string{"admin@:*"})
+	assertRule(t, policy.ACLs[4], "accept", []string{"uuid1@"}, []string{"uuid1@:*"})
+}
+
+func TestGenerateHubSpokePolicy_NoNormalUsers(t *testing.T) {
+	policy := GenerateHubSpokePolicy([]string{"zeabur"}, nil)
+
+	if len(policy.ACLs) != 2 {
+		t.Fatalf("expected 2 rules, got %d", len(policy.ACLs))
+	}
+
+	assertRule(t, policy.ACLs[0], "accept", []string{"zeabur@"}, []string{"*:*"})
+	assertRule(t, policy.ACLs[1], "accept", []string{"*"}, []string{"zeabur@:*"})
+}
+
+func assertRule(t *testing.T, rule ACLRule, action string, src, dst []string) {
+	t.Helper()
+	if rule.Action != action {
+		t.Errorf("expected action %q, got %q", action, rule.Action)
+	}
+	if len(rule.Sources) != len(src) {
+		t.Errorf("expected %d sources, got %d", len(src), len(rule.Sources))
+		return
+	}
+	for i := range src {
+		if rule.Sources[i] != src[i] {
+			t.Errorf("source[%d]: expected %q, got %q", i, src[i], rule.Sources[i])
+		}
+	}
+	if len(rule.Destinations) != len(dst) {
+		t.Errorf("expected %d destinations, got %d", len(dst), len(rule.Destinations))
+		return
+	}
+	for i := range dst {
+		if rule.Destinations[i] != dst[i] {
+			t.Errorf("destination[%d]: expected %q, got %q", i, dst[i], rule.Destinations[i])
+		}
+	}
+}