Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5808: Uninstall Webform module #1625

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

codechefmarc
Copy link
Collaborator

@codechefmarc codechefmarc commented Sep 18, 2024

READY FOR REVIEW

Summary

  • Removes config for hs_webform module, paragraphs, and related field config
  • Removes hs_webform dependencies from config ignored configs
  • Uninstalls the hs_webform module
  • Removes config for webform and webform_ui modules
  • Uninstalls webform and webform_ui modules
  • Does not remove hs_webform or webform from the filesystem - to be done in a subsequent PR

Need Review By (Date)

2024-09-23

Urgency

low

Steps to Test

  1. Login to the site as an admin
  2. Visit the paragraph types page /admin/structure/paragraphs_type and verify that there is no longer a "Webform" paragraph type (hs_webform)
  3. Visit the modules listing page /admin/modules and verify that the following modules are now uninstalled: hs_webform, webform_ui and webform.

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat September 18, 2024 00:18 Destroyed
@codechefmarc codechefmarc self-assigned this Sep 18, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat September 18, 2024 00:52 Destroyed
@codechefmarc codechefmarc marked this pull request as ready for review September 18, 2024 01:05
Base automatically changed from 11.2.4-release to develop September 18, 2024 15:31
@cienvaras cienvaras changed the base branch from develop to 11.2.5-release September 18, 2024 17:29
@ahughes3 ahughes3 temporarily deployed to Tugboat September 18, 2024 17:40 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc Looks good, just some minor details to fix, please check the inline comments.

There's an error in the codeception tests, it seems that there's an extra item in the shortcuts menu. It doesn't seem to be related to your changes, but please take a look if you have time available.

@ahughes3 ahughes3 temporarily deployed to Tugboat September 18, 2024 19:44 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat September 18, 2024 20:06 Destroyed
@codechefmarc
Copy link
Collaborator Author

@cienvaras - Config changes made. Also removed a default content of adding a "Manage webforms" shortcut to new sites - that seemed to initially clear up the codeception test, but then there were other errors about adding a course page and then again shortcuts as well. So not sure. If you find anything, please let me know. Thanks!

@ahughes3 ahughes3 temporarily deployed to Tugboat September 24, 2024 17:18 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc Thanks for the fixes! Tests are passing now, I just had to update the test to match the new number of shortcuts after removing the webforms one.

@ahughes3 It's ready for your review.

@cienvaras cienvaras assigned ahughes3 and unassigned codechefmarc Sep 24, 2024
@joegl joegl changed the base branch from develop to 11.3.1-release October 3, 2024 16:35
@ahughes3 ahughes3 temporarily deployed to Tugboat October 8, 2024 18:49 Destroyed
Base automatically changed from 11.3.1-release to develop October 16, 2024 15:43
@ahughes3 ahughes3 temporarily deployed to Tugboat October 17, 2024 22:24 Destroyed
@cienvaras cienvaras changed the base branch from develop to 11.4.1-release October 17, 2024 22:25
@ahughes3 ahughes3 temporarily deployed to Tugboat October 17, 2024 22:53 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat October 17, 2024 22:57 Destroyed
@cienvaras
Copy link
Collaborator

@joegl I just noticed that some of the feedback you gave us for #1643 also applies here. I'll add the fixes and let you know when it's ready for review again.

@cienvaras cienvaras assigned cienvaras and unassigned joegl Oct 21, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat October 22, 2024 15:21 Destroyed
@cienvaras
Copy link
Collaborator

@joegl PR updated and ready to review again. Thanks!

@cienvaras cienvaras assigned joegl and unassigned cienvaras Oct 22, 2024
Base automatically changed from 11.4.1-release to develop October 30, 2024 14:39
@cienvaras cienvaras changed the base branch from develop to 11.5.1-release October 30, 2024 21:54
@ahughes3 ahughes3 temporarily deployed to Tugboat November 5, 2024 19:52 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 5, 2024 21:03 Destroyed
Base automatically changed from 11.5.1-release to develop November 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants