-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5808: Uninstall Webform module #1625
base: develop
Are you sure you want to change the base?
Conversation
…-5808--remove-webform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc Looks good, just some minor details to fix, please check the inline comments.
There's an error in the codeception tests, it seems that there's an extra item in the shortcuts menu. It doesn't seem to be related to your changes, but please take a look if you have time available.
docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.install
Outdated
Show resolved
Hide resolved
config/default/field.field.node.hs_basic_page.field_hs_page_components.yml
Show resolved
Hide resolved
config/default/field.field.node.hs_private_page.field_hs_priv_page_components.yml
Show resolved
Hide resolved
@cienvaras - Config changes made. Also removed a default content of adding a "Manage webforms" shortcut to new sites - that seemed to initially clear up the codeception test, but then there were other errors about adding a course page and then again shortcuts as well. So not sure. If you find anything, please let me know. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc Thanks for the fixes! Tests are passing now, I just had to update the test to match the new number of shortcuts after removing the webforms one.
@ahughes3 It's ready for your review.
…-5808--remove-webform
…-5808--remove-webform
…-5808--remove-webform
@joegl PR updated and ready to review again. Thanks! |
…-5808--remove-webform
READY FOR REVIEW
Summary
hs_webform
module, paragraphs, and related field confighs_webform
dependencies from config ignored configshs_webform
modulewebform
andwebform_ui
moduleswebform
andwebform_ui
moduleshs_webform
orwebform
from the filesystem - to be done in a subsequent PRNeed Review By (Date)
2024-09-23
Urgency
low
Steps to Test
/admin/structure/paragraphs_type
and verify that there is no longer a "Webform" paragraph type (hs_webform
)/admin/modules
and verify that the following modules are now uninstalled:hs_webform
,webform_ui
andwebform
.PR Checklist