feat(components/molecule/collapsible): Custom toggle button and butto…#2466
Closed
feat(components/molecule/collapsible): Custom toggle button and butto…#2466
Conversation
hpintos
requested review from
andresin87,
andresz1,
arnau-rius,
kikoruiz,
rmoralp and
sui-bot
as code owners
|
quinwacca
approved these changes
Nov 16, 2022
xmurcia
approved these changes
Nov 16, 2022
andresin87
reviewed
Nov 17, 2022
| icon, | ||
| showText, | ||
| hideText, | ||
| toggleButton: ToggleButton, |
Member
There was a problem hiding this comment.
we prefer element over elementType
andresin87
reviewed
Nov 17, 2022
| /** | ||
| * Custom toggle button | ||
| */ | ||
| toggleButton: PropTypes.node, |
Member
There was a problem hiding this comment.
you are using it as a elementType, not a node
andresin87
reviewed
Nov 17, 2022
Comment on lines
+90
to
+99
| <button | ||
| type="button" | ||
| className={BUTTON_CLASS} | ||
| onClick={toggleCollapse} | ||
| > | ||
| <span className={BUTTON_CONTENT_CLASS} tabIndex="-1"> | ||
| {collapsed ? showText : hideText} | ||
| <span className={iconClassName}>{icon}</span> | ||
| </span> | ||
| </button> |
Member
There was a problem hiding this comment.
This part whould be componentized on a different file. Call it CollapseToogleButton.
andresin87
requested changes
Nov 17, 2022
Member
andresin87
left a comment
andresin87
left a comment
There was a problem hiding this comment.
lets schedule a pair programming session.
andresin87
force-pushed
the
feat/custom-toggle-btn-and-alignment
branch
from
ea080b0 to
720268a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n alignment
Category/Component
🔍 Show
TASK:
Types of changes
Description, Motivation and Context
We add two new features for this component:
This solves some UX requests made
Screenshots - Animations