❓ fix(components/molecule/notification): Fix MoleculeNotification buttons prop to avoid render container if no length #2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns prop to avoid render contain
jelowin
requested review from
sui-bot,
kikoruiz,
andresin87 and
andresz1
as code owners
jelowin
changed the title
jelowin
changed the title
jelowin
changed the title
jelowin
changed the title
andresin87
reviewed
Oct 30, 2023
| @@ -131,9 +131,9 @@ const MoleculeNotification = ({ | |||
| </div> | |||
| )} | |||
| </div> | |||
| {buttons && ( | |||
| {buttons.length ? ( | |||
There was a problem hiding this comment.
Suggested change
| {buttons.length ? ( | |
| {buttons?.length ? ( |
and remove the default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
molecule/notification
#2609:
Description, Motivation and Context
Types of changes
Screenshots - Animations