fix: include cached-property as a conditional dependency#223
Merged
frozenIceage merged 1 commit intomasterfrom Feb 5, 2026
Merged
fix: include cached-property as a conditional dependency#223frozenIceage merged 1 commit intomasterfrom
frozenIceage merged 1 commit intomasterfrom
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Before this commit, we were loading cached-property as a dependency in `setup.py`, which is flawed, as this choice happens when the package is built and not when the package is installed. I.e. whether osc-tiny depends on cached-property depends on the builder's python version, not on the user's.
dcermak
force-pushed
the
proper-dependencies
branch
from
837e993 to
28c5028
Compare
Contributor
|
LGTM, thank you for this fix! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, we were loading cached-property as a dependency in
setup.py, which is flawed, as this choice happens when the package is built and not when the package is installed. I.e. whetherosc-tinydepends on cached-property depends on the builder's python version, not on the user's.