-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CVW-030] 웹소켓 & 환율정보 획득 과정 에러처리 #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
제가 이해한 방식은 아래와 같습니다.
혹시 제가 잘못 이해한 부분이 있다면 말씀해주세요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경된 점
웹소켓 & 환율정보 처리(도메인) 에러처리 플로우
AlertModel
AlertModel
은 Alert표출에 필요한 정보를 담고 있습니다.AlertAction
을 통해 버튼 유저가 버튼을 클릭시 수행할 작업을 전달할 수 있습니다.I18N
Alert에 표시되는 정보들은 I18N을 지원합니다.
복잡한 키관리를 간소화 하기위해
TextKey
타입을 생성하였습니다.런타임시 키값 불일치를 방지하기 위해 키값에 일치하는 언어값이 존재하는지 확인하는 테스트 코드를 작성했습니다.
Alert시현영상
버튼을 동적으로 새성하기 위해 커스텀 Alert를 구현했습니다.
Alert동작으로 부터 상태를 회복합니다.