-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gpu code #58
Open
abouzied-nasar
wants to merge
170
commits into
SWIFTSIM:master
Choose a base branch
from
abouzied-nasar:gpu_code
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gpu code #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded cuda and hip Makefile.ac
…rc/cuda/part_gpu.h
… not being found by the cuda library
… b to stop an error related to prototype overloading in dummy.c in src/cuda
… task.c and h queue.h and removed unused vars from runner_doiact_functions_hydro_gpu.h
…n main dir instead of src
…off because I have not made gpu tasks yet
…Not sure where the issue is
… tasks. Code now hangs so there must be some issue with task activation. problem for tomorrow!
This is the current state of the gpu code as implemented in the latest SWIFT version. It's not working properly yet as I think there is an issue with the GPU task activation (the code hangs before the first time step) and I need to implement a mechanism for creating deps for unpack tasks whic do not belong to a cell |
…ave been source of hanging bug. Not the case :(
… deps for unpack tasks. CPU version works perfectly but GPU code now hangs for some reason
…gpu and re-worked runner_main_clean.cu but code still hangs
…gpu and re-worked runner_main_clean.cu but code still hangs
…. Removed them all and code still hangs. Will copy back previous files innext commit
…ing to with not unskipping tasks properly. IFDEFs are totally correct and code does not hang when GPU code commented out
…ng. Code is doing something but I don't think it's actually progressing through time steps
…regions in scheduler enqueue function
…fix to match the gradient and force ones
…ashing due to memcpys
…zero just call scheduler_done()
…ixed counter decrementation in scheduler_enqueue for the case when cell->hydro.count == 0
…re now not activated in cell_unskip
…_doiact_functions_hydro_gpu.h
….yml set the max time step to 1e-6 to prevent code crashing when there are only a few particle updates. Need to modify GPU code to work for this case. Also set count_max_parts_tmp in runner_main2 to 10 times target to prevent running out of bounds for unsplit cells
…only gpu tasks are not activated if they have zero particles
…sity tasks in previous commit. I am now extending the revised splitting strategy to gradient and force subtypes
…dency graphs are looking good. Split domain with 8^3 cells into 16^3 cells with no issues
…son to with ideal size of ~64 parts per cell and 2 million parts. Will now test on G-H Isamabrd-AI
… and how many have more
…rticles in a task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.