Skip to content

Conversation

@dayo09
Copy link
Contributor

@dayo09 dayo09 commented Nov 3, 2022

This commit renames _initCfgList to _getCfgList.
because it doesn't keep the cfglist and just use and dispose it.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]


From #1446

This commit renames _initCfgList to _getCfgList.
because it doesn't keep the cfglist and just use and dispose it.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 added the 1 approval 1 approval required to be merged label Nov 3, 2022
@dayo09 dayo09 requested a review from a team November 3, 2022 08:31
@dayo09
Copy link
Contributor Author

dayo09 commented Nov 3, 2022

@Samsung/one-vscode PTAL :-D

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit fbd12ae into Samsung:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval 1 approval required to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants