[MPQEditor] Implement 'validateMPQName' #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamalakhov
force-pushed
the
manual_MPQ_defautMPQ_br
branch
from
53357da to
84d8f1e
Compare
dayo09
reviewed
Apr 3, 2023
Contributor
There was a problem hiding this comment.
Suggested change
| assert(retValue === undefined); | |
| assert(retValue === undefined); |
You can use assert.isUndefined(retvalue)
From clean code's view, better to read the human language. :-D
dayo09
reviewed
Apr 3, 2023
Contributor
|
Thanks! It's even better to understand the code with the unit test. |
stamalakhov
force-pushed
the
manual_MPQ_defautMPQ_br
branch
from
eaaab7a to
69525fd
Compare
dayo09
reviewed
Apr 3, 2023
stamalakhov
force-pushed
the
manual_MPQ_defautMPQ_br
branch
2 times, most recently
from
97fa678 to
b06c973
Compare
seanshpark
reviewed
Apr 3, 2023
seanshpark
reviewed
Apr 4, 2023
stamalakhov
force-pushed
the
manual_MPQ_defautMPQ_br
branch
from
b06c973 to
2725b54
Compare
stamalakhov
force-pushed
the
manual_MPQ_defautMPQ_br
branch
from
2725b54 to
bb2094a
Compare
This commit implements 'validateMPQName' and adds tests for it. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
manual_MPQ_defautMPQ_br
branch
from
bb2094a to
dd260dc
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements 'validateMPQName' and adds tests for it.
Fresh draft: #1511
Previous draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]