[MPQEditor] Implement providing model nodes info. #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamalakhov
force-pushed
the
manual_MPQ_getNodes_br
branch
from
983d162 to
8333e92
Compare
seanshpark
reviewed
Apr 11, 2023
src/MPQEditor/MPQEditor.ts
Outdated
Contributor
There was a problem hiding this comment.
@jyoungyun , is ONE-toolchain name appropriate? or if not, can you please suggest?
Collaborator
There was a problem hiding this comment.
@stamalakhov How about using just Toolchain? ONE-vscode supports two types of toolchains, ONE and TRIV. And each toolchain contains one-compiler so user can use onecc command in any toolchain.
Contributor
Author
There was a problem hiding this comment.
@stamalakhov How about using just
Toolchain? ONE-vscode supports two types of toolchains, ONE and TRIV. And each toolchain containsone-compilerso user can useonecccommand in any toolchain.
Ok. I see. I'll change it to Toolchain. Thank you.
stamalakhov
force-pushed
the
manual_MPQ_getNodes_br
branch
from
8333e92 to
94f89f5
Compare
This commit implements providing model nodes info. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
manual_MPQ_getNodes_br
branch
from
94f89f5 to
0688b8e
Compare
dayo09
approved these changes
Apr 14, 2023
Contributor
dayo09
left a comment
dayo09
left a comment
There was a problem hiding this comment.
LGTM, sorry for the late response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements providing model nodes info.
Fresh draft: #1511
Previous draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]