[MPQEditor] Update MPQData for visq path. #1547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayo09
reviewed
May 2, 2023
src/MPQEditor/MPQData.ts
Outdated
Contributor
There was a problem hiding this comment.
(optional) FYI, typescript provides 'get' 'set' keywords for easier getter/setter implementation. 😄
Contributor
Author
There was a problem hiding this comment.
(optional) FYI, typescript provides 'get' 'set' keywords for easier getter/setter implementation. 😄
@dayo09
Thank you! I've changed the draft and this PR.
This draft introduces VISQ data. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
manual_MPQ_visq_data_br
branch
from
9fc15f5 to
65e4d43
Compare
dayo09
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates MPQData for handling visq path.
Its correctness is tested in #1543
Fresh draft: #1543
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]