Skip to content

Nimbus jose jwt library upgrade due to vulnerabilities #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Nimbus jose jwt library upgrade due to vulnerabilities #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ dependencies {
implementation group: 'org.json', name: 'json', version: '20190722'

//https://mvnrepository.com/artifact/com.nimbusds/nimbus-jose-jwt
implementation group: 'com.nimbusds', name: 'nimbus-jose-jwt', version: '8.3'
implementation group: 'com.nimbusds', name: 'nimbus-jose-jwt', version: '9.12'
Copy link
Member

@preetkaran20 preetkaran20 Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SampathKumarAmex this should not break our existing vulnerable levels. Can you please check vulnerable level using this library and see if that is working as expected

Copy link
Contributor Author

@SampathKumarAmex SampathKumarAmex Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide more info on how to test that? Do you have any documentation covering that part?

It's good to have some test for this if feasible.

Copy link
Member

@preetkaran20 preetkaran20 Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SampathKumarAmex we need to start VulnerableApp, go to UI, and test that each level doesn't break.

Copy link
Member

@preetkaran20 preetkaran20 Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we are lacking unit tests and other things right now.


// https://mvnrepository.com/artifact/commons-io/commons-io
implementation group: 'commons-io', name: 'commons-io', version: '2.7'
Expand Down