Repository navigation
macOS: Replace deprecated CVDisplayLink calls in main and apple subproject - #1288
Merged
SaschaWillems merged 3 commits intoAug 28, 2026
Merged
Conversation
Owner
|
Thanks for this contribution. Very much appreciated 👍🏻 |
Contributor
Author
|
Happy to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1287.
This PR does the following:
vulkanexamplebaseto replace deprecatedCVDisplayLinkcalls withCAMetalDisplayLinkinstead. This means the main project will compile and work on macOS 14 (Sonoma) and later. Sonoma is currently the oldest supported version of macOS (but will likely become unsupported this fall 2026).CVDisplayLinkcalls withCADisplayLinkinstead. Again, This means the apple subproject will compile and work on macOS 14 (Sonoma) and later. The iOS portion of the subproject has already been usingCADisplayLinkfor some time so that portion does not change.setFrameIntervalfunction withsetPreferredFrameRateRangeviewDidAppearentry point to mirror the iOS code.dynamicrenderinglocalreadanddescriptorheapuntypedin examples.hTested on macOS Sequoia 15.7.9 on x86_64, a real iPhone 16 (iOS 26.6), and the iOS Simulator on x86_64 (iOS 26.2).
Tested on macOS 26.6 on Apple Silicon (M1 Air) with both MoltenVK and KosmicKrisp drivers (SDK 1.4.357).