-
Notifications
You must be signed in to change notification settings - Fork 2
build(workflows): execute the CI via GitHub Actions #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
247e449
to
2c4e926
Compare
ff626ff
to
9252255
Compare
da32292
to
a50f1bc
Compare
86b272a
to
29ade66
Compare
95b6301
to
bde3d17
Compare
bde3d17
to
ee9b5aa
Compare
jobs: | ||
detect-modules: | ||
name: Detect the Go modules declared in go-utils | ||
runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do we want to try and run on 24.04
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can. We never faced any issue with Go related to the OS hence I'm tempted to keep trusting Go and not test on both OS (22.04 and 24.04). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could slightly move to 24.04, but it is fine as is. I am mostly wondering because it caused issues on codeship, so we might want to be "early than late".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue we faced on CodeShip with Ubuntu 24.04 is that with this version, they stopped deploying a MongoDB. As our CI scripts supposed that MongoDB is installed, they all suddenly failed. So it's not really related to the new OS version but to a major change in their base image.
Fix #376
I want to test this for a few days on
master
. If we eventually don't face any issue with this setup, I'll eventually remove CodeShip integration on this repository.CHANGELOG.md