refactor(icon-import): change alias separator to comma (#1885)

In our Figma icon file, not all icon aliases were separated correctly
(some used `|`, others `,`).
This is not aligned in Figma to always use comma so we also reflect this
change in our CLI.

.changeset/fast-rivers-learn.md

@@ -0,0 +1,15 @@
+---
+"@sit-onyx/icons": minor
+---
+
+feat: update icons
+
+Also fixed icon aliases in the metadata for most icons which are now separated correctly
+
+#### New icons
+
+- heptagon-cloud-foundry
+
+#### Modified icons
+
+- sidebar-arrow-right

.changeset/swift-fans-rhyme.md

@@ -0,0 +1,10 @@
+---
+"@sit-onyx/figma-utils": major
+---
+
+refactor(icon-import): change alias separator to comma
+
+To use the previous behavior, change the alias separator to `|`:
+
+- if using CLI: add flag `-s "|"`
+- if using function: `parseComponentsToIcons({ aliasSeparator: "|" })`

packages/figma-utils/src/commands/import-icons.ts

@@ -35,7 +35,7 @@ export const importIconsCommand = new Command("import-icons")
   .option(
     "-s, --alias-separator <string>",
     "Separator for icon alias names (which can be set to the component description in Figma).",
-    "|",
+    ",",
   )
   .action(importIconsCommandAction);
 

packages/figma-utils/src/icons/parse.ts

@@ -12,7 +12,7 @@ export type ParseIconComponentsOptions = {
   /**
    * Separator for icon alias names (which can be set to the component description in Figma).
    *
-   * @default "|"
+   * @default ","
    */
   aliasSeparator?: string;
 };
@@ -28,7 +28,7 @@ export const parseComponentsToIcons = (options: ParseIconComponentsOptions): Par
         id: component.node_id,
         name: component.name,
         aliases: component.description
-          .split(options.aliasSeparator ?? "|")
+          .split(options.aliasSeparator ?? ",")
           .map((alias) => alias.trim())
           .filter((i) => i !== ""),
         category: component.containing_frame.name.trim(),