-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add relevant events logging #1880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb7cab3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
changed the title
add relevant events logging
chore: add relevant events logging
Sep 17, 2024
larsrickert
requested changes
Sep 17, 2024
Co-authored-by: Lars Rickert <[email protected]>
…com/SchwarzIT/onyx into joca96/feat-1603-add-native-logging
…com/SchwarzIT/onyx into joca96/feat-1603-add-native-logging
…com/SchwarzIT/onyx into joca96/feat-1603-add-native-logging
…feat-1603-add-native-logging
larsrickert
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Co-authored-by: Lars Rickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: JoCa96 <[email protected]>
larsrickert
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Storybook Util
withNativeEventLoggingFor
is introduced.It generates Storybook
ArgTypes
that allow us to document and log relevant native events in Storybook.These can be merged with other
ArgTypes
.The native events will be documented in a new section "Relevant HTML Events".
Relates to #1603