fix: returnUrl from back end was being discarded

[GBirkel]

Description

The "returnUrl" value passed to/from the back end was being ignored at the end of the journey. These minor changes detect a "returnUrl" that's part of a successful OIDC login from the v4 back end, and use the value in subsequent navigation after the login page.

Motivation

Together with the changes in SciCatProject/scicat-backend-next#1815 , this makes "returnUrl" work as designed.

Fixes / Changes:

Detecting and extracting "returnUrl" in a successful OIDC redirect. Using "returnUrl" in place of "returnURL" for consistency.

Tests included

Tests pass as before.

Documentation

No documentation changes needed.

Backend version

No specific back end is mandatory, but for "returnUrl" to fully work, the changes in SciCatProject/scicat-backend-next#1815 should be integrated as well.

Summary by Sourcery

Improve handling of returnUrl during OIDC authentication to ensure consistent redirect behavior across different backend versions

Bug Fixes:

• Fixed discarding of returnUrl during OIDC login process, ensuring users are redirected to the correct page after authentication

Enhancements:

• Updated returnUrl handling to support both backend v3 and v4 authentication flows
• Standardized returnUrl parameter naming across components

[sourcery-ai]

Hey @GBirkel - I've reviewed your changes - here's some feedback:

Overall Comments:

• It might be clearer to use a constant for the query parameter name returnUrl to avoid typos and improve maintainability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[omkar-ethz]

Proposal to discard this PR and the related backend PR: SciCatProject/scicat-backend-next#1815. The feature works as expected, please get in touch if you are having issues with the exisiting implementation.

[nitrosx]

Fine by me.
Thank you for stepping in

[nitrosx]

Are we all in agreement to close it?

[GBirkel]

This feature definitely didn't work for me until I made the above changes, along with the accompanying back-end PR. I could not successfully pass a return URL from the front end to the back end and have it used in a redirect, and as a result, users who were unauthenticated were always being dropped at the default starting location rather than where they'd originally been.

[GBirkel]

That said, if it is breaking current deployments, go ahead and back it out. I'm using a fork for my own deployment and will just avoid pulling in master until I have another look at the situation.

[omkar-ethz]

Just tested, the returnUrl was only being respected when OIDC_SUCCESS_URL was /auth-callback. This does fix the bug when OIDC_SUCCESS_URL is /login, thanks!

[omkar-ethz]

This feature definitely didn't work for me until I made the above changes, along with the accompanying back-end PR. I could not successfully pass a return URL from the front end to the back end and have it used in a redirect, and as a result, users who were unauthenticated were always being dropped at the default starting location rather than where they'd originally been.

Added my comment about /auth-callback vs /login. Can confirm the feature did not work when OIDC_SUCCESS_URL set to /login, and only worked when it was /auth-callback. Sorry for the confusion. Also in favor to merge this PR.