fix(pipe): throw an error when malformed json is passed #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofyalaski
changed the title
sofyalaski
changed the title
HayenNico
reviewed
Sep 4, 2025
There was a problem hiding this comment.
This looks good, but will only cover API v4 right now. #2172 indicates a similar fix is needed on the v3 controller. I think the same logic could be inserted in DatasetsController.getFilters
nitrosx
approved these changes
Sep 4, 2025
|
@HayenNico you are correct |
HayenNico
approved these changes
Sep 4, 2025
|
And keep in mind possible interactions with #1926 |
bpedersen2
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a try-catch block for parsing passed filter as a json string, and when that fails it throws an error . Before it was failing with 500 "internal server error"
Motivation
#2172
Fixes
Changes:
Tests included
Documentation
official documentation info